[bitbake-devel] [PATCH] runqueue: add mc to pending hash index

[Richard Purdie]

On Fri, 2019-11-29 at 09:11 +0800, Kang Kai wrote:
> On 2019/11/29 上午1:51, Richard Purdie wrote:
> > On Thu, 2019-11-28 at 17:27 +0800, kai.kang at windriver.com wrote:
> > > From: Kai Kang <kai.kang at windriver.com>
> > > 
> > > When build multiconfig target by following steps in section
> > > "Enabling
> > > Multiple Configuration Build Dependencies" in yocto dev-manual
> > > which
> > > adds dependency between multiconfig targets:
> > > 
> > > do_image[mcdepends] = "mc:x86:arm:core-image-minimal:do_rootfs"
> > > 
> > > it shows a lot of warnings, such as:
> > > 
> > > > WARNING: Deferring
> > > >    mc:x86:virtual:native:/path/to/meta/recipes-
> > > > support/nss/nss_3.45.bb:do_populate_sysroot
> > > >    after
> > > >    mc:arm:virtual:native:/path/to/meta/recipes-
> > > > support/nss/nss_3.45.bb:do_populate_sysroot
> > > In function pending_hash_index it only checks PN, taskname and
> > > hash.
> > > But
> > > they are same for multiconfig native and allarch packages. Add
> > > multiconfig
> > > to pending hash index too to make the index unique.
> > > 
> > > Ref:
> > > https://www.yoctoproject.org/docs/latest/dev-manual/dev-manual.html#dev-enabling-multiple-configuration-build-dependencies
> > > 
> > > Signed-off-by: Kai Kang <kai.kang at windriver.com>
> > This patch completes defeats the point of this code, disabling it.
> > Its
> > the wrong thing to do, we want this code to be active.
> > 
> > The bug is that this should not be a warning, probably just a note.
> > 
> > We need it to be a note so that we can tell the mechanism is in
> > action
> > from build output logs.
> 
> I have sent a patch to change from warning to note. But without 
> comment,  I thought it should be fixed in this function.
> Would you like to review the patch "runqueue.py: not show warning
> for 
> deferred multiconfig task" on Oct 17, please?

I thought I'd seen a proper fix!

That patch is correct, not sure why it wasn't merged but I'd thought it
should be. Its merged now, thanks.

Cheers,

Richard