[bitbake-devel] [RFC][PATCH 2/2] fetch2/npm.py: refactor the npm fetcher

[Paul Eggleton]

On Thursday, 24 October 2019 3:27:11 AM NZDT Mark Hatle wrote:
> On 10/23/19 8:08 AM, Jean-marie Lemetayer wrote:
> > Thank you again. The former npm support does not have any tests so I did not
> > think about it. I will add some basic tests in the v2.
> 
> If you need some pointers on where and how to write the tests, please let me
> know.  I've had to write a number of them for the gitsm fetcher.
> 
> Hint: https://git.openembedded.org/bitbake/tree/lib/bb/tests/fetch.py
> 
> Stuff I added is mostly found by looking for 'test_git_submodule...'
> 
> I'd expect we need a new test_npm_.... series.

Right, but if the functionality now relies on code in OE, then to fully test it you'd need to add oe-selftest tests in OE as well.

Cheers,
Paul


-- 

Paul Eggleton
Intel System Software Products