[bitbake-devel] [PATCH 1/2] runqueue/siggen: Optimise hash equiv queries

Richard Purdie richard.purdie at linuxfoundation.org
Tue Sep 10 14:15:54 UTC 2019


We only have hash equivalence for setscene tasks so only query the server
for those, reducing the number of connections needed.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
 lib/bb/runqueue.py | 1 +
 lib/bb/siggen.py   | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index addb2bb82f..45bfec8c37 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -1173,6 +1173,7 @@ class RunQueueData:
                     self.prepare_task_hash(tid)
 
         bb.parse.siggen.writeout_file_checksum_cache()
+        bb.parse.siggen.set_setscene_tasks(self.runq_setscene_tids)
 
         #self.dump_data()
         return len(self.runtaskentries)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index b503559305..8d3f2e8784 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -106,6 +106,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
         self.taints = {}
         self.gendeps = {}
         self.lookupcache = {}
+        self.setscenetasks = {}
         self.basewhitelist = set((data.getVar("BB_HASHBASE_WHITELIST") or "").split())
         self.taskwhitelist = None
         self.init_rundepcheck(data)
@@ -151,6 +152,9 @@ class SignatureGeneratorBasic(SignatureGenerator):
 
         return taskdeps
 
+    def set_setscene_tasks(self, setscene_tasks):
+        self.setscenetasks = setscene_tasks
+
     def finalise(self, fn, d, variant):
 
         mc = d.getVar("__BBMULTICONFIG", False) or ""
@@ -394,6 +398,10 @@ class SignatureGeneratorUniHashMixIn(object):
 
         taskhash = self.taskhash[tid]
 
+        # If its not a setscene task we can return
+        if self.setscenetasks and tid not in self.setscenetasks:
+            return taskhash
+
         key = self.__get_task_unihash_key(tid)
 
         # TODO: This cache can grow unbounded. It probably only needs to keep
-- 
2.20.1



More information about the bitbake-devel mailing list