<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Nov 21, 2012 at 2:21 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":3f">In normal usage, we never hit the timeout issue. If we do, it becomes obvious<br>
that the current error handling is not good enough. The request may have made it<br>
to the server and the answer will get queued. This means the next command may get<br>
the return value from the previous command with suitably puzzling results.<br>
<br>
Without rewriting large sections of code, its not possible to avoid this problem.<br>
It is better to increase the timeout to several seconds giving the server a chance<br>
to respond and if it does timeout, hard exit since recovery is not possible with the<br>
code base today.<br>
<br>
I'd be happy to see the structure of this code improved but this quick fix at least<br>
stops corrupted builds from happening which has to be a good thing.<br>
<br>
Signed-off-by: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>></div></blockquote></div><br><br clear="all"><div>This code is run in UI context, not server context, no? So the UI should be checking the return of runCommand, seeing the error, and aborting itself in whatever clean fashion is appropriate, rather than the rather less so immediate sys.exit. Given that, I don't really see how switching to bb.fatal here is buying us much. If we truly want that error path to be different from that of other command failures, then I would think that raising an appropriate exception (e.g. something other than SystemExit) would be better.</div>
-- <br>Christopher Larson<br>
</div>