<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 15, 2013 at 7:27 AM, Paul Eggleton <span dir="ltr"><<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1zw">BitBake commit 7c568132c54a21161de28907159f902462f1e2bb resulted in a<br>
fairly serious performance regression during parsing, almost doubling<br>
the time taken to do a full parse and almost certainly impacting<br>
performance during building. The expandKeys function is called<br>
frequently, and if we avoid using keys() and instead just use the normal<br>
variable lookup mechanism, performance is restored.<br>
<br>
Signed-off-by: Paul Eggleton <<a href="mailto:paul.eggleton@linux.intel.com">paul.eggleton@linux.intel.com</a>></div></blockquote></div><br>I would suggest using the existing __contains__ mechanism provided by DataSmart.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra"> if newval in alterdata:</div><div class="gmail_extra"><br></div><div class="gmail_extra">Should be sufficient, as MutableMapping from collections provides __contains__ from Mapping, which in turn uses __getitem__.<br>
-- <br>Christopher Larson</div></div>