<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 25, 2013 at 3:59 PM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":11v" style="overflow:hidden">One of the current frustrations with the sstate checksums is that<br>
code like base_contains('X', 'y',...) adds a full dependency on X<br>
and varies depend even on whitespace changes in X.<br>
<br>
This patch adds special handling of the contains functions to expand<br>
the first parameter and check for the flag specified by the second<br>
parameter (assuming its a string).<br>
<br>
The result is then appended to the value of the variable with a "Set"<br>
or "Unset" status. If the flag is added/removed, the stored variable<br>
value changes and hence the checksum changes. No dependency on X<br>
is added so it is free to change with regard to other flags or<br>
whitespace.<br>
<br>
This code is far from ideal, ideally we'd have properly typed variables<br>
however it fixes a major annoyance of the current checksums and<br>
is of enough value its worth adding in a stopgap solution. It shouldn't<br>
significantly restrict any propely typed variable implementation in<br>
future.<br>
<br>
Signed-off-by: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>></div></blockquote></div><br>Looks good, will be very helpful for now.</div><div class="gmail_extra">
<br></div><div class="gmail_extra">Signed-off-by: Christopher Larson <<a href="mailto:chris_larson@mentor.com">chris_larson@mentor.com</a>><br>-- <br>Christopher Larson</div></div>