<div dir="ltr">Just now saw this email - sorry for the delay,<div><br></div><div>I used USER_CLASSES just because this is how it's enabled in the default local.conf ...</div><div><br></div><div>Alex</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Dec 19, 2013 at 9:21 PM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, 2013-12-18 at 19:26 +0000, Alex DAMIAN wrote:<br>
> From: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
><br>
> Toaster needs buildstats to be enabled in order to<br>
> be able to collect task running stats. This patch<br>
> adds buildstats to the running configuration in toaster mode.<br>
><br>
> Signed-off-by: Alexandru DAMIAN <<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>><br>
> ---<br>
> bin/toaster | 7 ++++++-<br>
> 1 file changed, 6 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/bin/toaster b/bin/toaster<br>
> index 38e71ac..d6c3175 100755<br>
> --- a/bin/toaster<br>
> +++ b/bin/toaster<br>
> @@ -61,10 +61,13 @@ function webserverStartAll()<br>
> }<br>
><br>
> # Helper functions to add a special configuration file<br>
> +function initConfiguration()<br>
> +{<br>
> + echo "#Created by toaster start script" > ${BUILDDIR}/conf/$1<br>
> +}<br>
><br>
> function addtoConfiguration()<br>
> {<br>
> - echo "#Created by toaster start script" > ${BUILDDIR}/conf/$2<br>
> echo $1 >> ${BUILDDIR}/conf/$2<br>
> }<br>
><br>
> @@ -167,7 +170,9 @@ fi<br>
> case $CMD in<br>
> start )<br>
> start_success=1<br>
> + initConfiguration toaster.conf<br>
> addtoConfiguration "INHERIT+=\"toaster buildhistory\"" toaster.conf<br>
> + addtoConfiguration "USER_CLASSES+=\"buildstats\"" toaster.conf<br>
> if ! webserverStartAll; then<br>
> echo "Failed ${CMD}."<br>
> return 4<br>
<br>
</div></div>Why not just add this to the INHERIT? I'm trying to figure out if<br>
USER_CLASSES is special in some way and when we should use one and when<br>
we should use the other...<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alex Damian<div>Yocto Project<br></div><div>SSG / OTC </div></div>
</div>