<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 21, 2014 at 9:46 AM, Jacob Kroon <span dir="ltr"><<a href="mailto:jacob.kroon@mikrodidakt.se" target="_blank">jacob.kroon@mikrodidakt.se</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":12f" class="a3s" style="overflow:hidden">- funcname = ("__anon_%s_%s" % (self.lineno, self.filename.translate(string.maketrans('/.+-@', '_____'))))<br>
+ funcname = ("__anon_%s_%s" % (self.lineno, self.filename.translate(string.maketrans('/.+-@%', '______'))))</div></blockquote></div><br></div><div class="gmail_extra">I know it's not related to this particular patch, but there's no reason for us to call string.maketrans() inside of MethodPool.eval(), that should probably have been a class member, no reason to regenerate the translation table every time, after all :)<br>
-- <br>Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics
</div></div>