<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">Thank you for spotting this,<br><br>New patch will be sent with the next submission.<br><br>Thanks,<br>Alex<br></div></div><div class="gmail_extra">

<br><br><div class="gmail_quote">On Fri, Apr 4, 2014 at 4:20 PM, Paul Eggleton <span dir="ltr">&lt;<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="HOEnZb"><div class="h5">On Friday 04 April 2014 15:10:42 Alex DAMIAN wrote:<br>
&gt; From: Alexandru DAMIAN &lt;<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>&gt;<br>
&gt;<br>
&gt; This patch makes sure that we only load pytz-recognized<br>
&gt; timezones. Pytz is used to transform the timezone information<br>
&gt; for the database queries, and needs to be able to deal with<br>
&gt; the TIME_ZONE value that we set up.<br>
&gt;<br>
&gt; [YOCTO #6093]<br>
&gt;<br>
&gt; Signed-off-by: Alexandru DAMIAN &lt;<a href="mailto:alexandru.damian@intel.com">alexandru.damian@intel.com</a>&gt;<br>
&gt; ---<br>
&gt;  lib/toaster/toastermain/settings.py | 8 +++++++-<br>
&gt;  1 file changed, 7 insertions(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/lib/toaster/toastermain/settings.py<br>
&gt; b/lib/toaster/toastermain/settings.py index e26ee3c..e39b4cb 100644<br>
&gt; --- a/lib/toaster/toastermain/settings.py<br>
&gt; +++ b/lib/toaster/toastermain/settings.py<br>
&gt; @@ -64,7 +64,13 @@ else:<br>
&gt;      for dirpath, dirnames, filenames in os.walk(ZONEINFOPATH):<br>
&gt;          for fn in filenames:<br>
&gt;              filepath = os.path.join(dirpath, fn)<br>
&gt; -            zonefilelist[hashlib.md5(open(filepath).read()).hexdigest()] =<br>
&gt; filepath.lstrip(ZONEINFOPATH).strip() +            try:<br>
&gt; +                import pytz<br>
&gt; +                zonename = filepath.lstrip(ZONEINFOPATH).strip()<br>
&gt; +                if pytz.timezone(zonename) is not None:<br>
&gt; +<br>
&gt; zonefilelist[hashlib.md5(open(filepath).read()).hexdigest()] = zonename<br>
&gt; +          except Exception:<br>
&gt; +                pass<br>
<br>
</div></div>Please do not do blanket exception catching like this. You need to catch the<br>
exact class of exception you expect to receive.<br>
<br>
Cheers,<br>
Paul<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
<br>
Paul Eggleton<br>
Intel Open Source Technology Centre<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">Alex Damian<div>Yocto Project<br></div><div>SSG / OTC </div></div>
</div>