<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 3/13/2015 5:37 PM, Bernhard
Reutner-Fischer wrote:<br>
</div>
<blockquote
cite="mid:471B1967-EB47-4869-98B6-9A0750147888@gmail.com"
type="cite">
<pre wrap="">On March 13, 2015 10:12:00 PM GMT+01:00, Bernhard Reutner-Fischer <a class="moz-txt-link-rfc2396E" href="mailto:rep.dot.nop@gmail.com"><rep.dot.nop@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On March 13, 2015 8:41:37 PM GMT+01:00, "Woolley, Rob"
<a class="moz-txt-link-rfc2396E" href="mailto:rob.woolley@windriver.com"><rob.woolley@windriver.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 03/12/2015 12:30 PM, Richard Purdie wrote:
</pre>
</blockquote>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Patches 1/2 look good, I've run into the EPIPE issue myself and I
</pre>
</blockquote>
<pre wrap="">have
</pre>
<blockquote type="cite">
<pre wrap="">noticed the crazy logfile so those can likely be merged.
I'm less sure about 3, letting the user pipe the output to less when
needed would seem to be the better way to have this rather than
</pre>
</blockquote>
<pre wrap="">adding
</pre>
<blockquote type="cite">
<pre wrap="">in specific pagination support?
Cheers,
Richard
</pre>
</blockquote>
<pre wrap="">Sounds cool. The exception was bugging me, so I'm glad to hear those
ones look good.
As far as the 3rd patch is concerned: I remember when I first used
bitbake, I was surprised by the flood of data coming from those
options. I would suggest that doing the automatic paging provides a
better first impression and saves unnecessary typing.
I noticed that lib/image/help.py and lib/bsp/help.py have auto-paging
for the help command. I've CC'd Tom Zanussi for his opinion.
</pre>
</blockquote>
<pre wrap="">
Using PAGER is a good thing IMO.
Not so setting LESS or LV nor outsmarting users PAGER=cat nor
defaulting to less.
I would also not attempt to check access() et al, just let the user fix
her eventually broken export.
</pre>
</blockquote>
<pre wrap="">
PS:
<a class="moz-txt-link-freetext" href="http://comments.gmane.org/gmane.comp.version-control.patchwork/1144">http://comments.gmane.org/gmane.comp.version-control.patchwork/1144</a>
;)
</pre>
</blockquote>
<br>
Thanks for the feedback, Bernhard.<br>
<br>
I set defaults for LESS and LV based on what git does for its
automatic paging:<br>
<a href="https://github.com/git/git/blob/master/pager.c#L57">https://github.com/git/git/blob/master/pager.c#L77</a><br>
<br>
The part with cat is also inspired by git:<br>
<a href="https://github.com/git/git/blob/master/pager.c#L34">https://github.com/git/git/blob/master/pager.c#L51</a><br>
<a href="https://github.com/git/git/blob/master/pager.c#L57"></a><br>
I see the first 2 patches went in. I'm going to give the automatic
paging patch some more soak time.<br>
<br>
If anyone is interested in trying it out, I've created a gist for it
here:<br>
<a href="https://gist.github.com/rcwoolley/c662b8e1494c58b1a24d">https://gist.github.com/rcwoolley/c662b8e1494c58b1a24d<br>
</a><br>
Regards,<br>
Rob<br>
</body>
</html>