<div dir="ltr"><div class="gmail_extra">On Mon, Jul 6, 2015 at 8:13 AM, <span dir="ltr"><<a href="mailto:eu@felipetonello.com" target="_blank">eu@felipetonello.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":1vq" class="a3s" style="overflow:hidden">From: "Felipe F. Tonello" <<a href="mailto:eu@felipetonello.com">eu@felipetonello.com</a>><br>
<br>
Only do git submodule update after upack, otherwise the branch and commit id<br>
will be ignored, causing to run git submodules on a wrong ref.<br>
<br>
Since .gitmodules file is used to check if there is any submodule, we don't<br>
need to worry about copying .git/modules directory into the unpacked source<br>
tree.<br>
<br>
Signed-off-by: Felipe F. Tonello <<a href="mailto:eu@felipetonello.com">eu@felipetonello.com</a>></div></blockquote></div><br>We don’t want to be downloading from remote locations in do_unpack, only do_fetch. This patch will result in the opposite, which means the submodule sources won’t be included in the git mirror tarball, and it’ll be impossible to build with BB_NO_NETWORK=1. Also -c fetchall won’t result in all sources having been fetched, which defeats its purpose.<br>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>