<div dir="ltr"><div><div><div><div>Hi, Christopher, Richard:<br><br></div>Thanks for the reviewing! And sorry to this delayed feedback, I was on a vacation.<br></div>I had send another patch set which tweaked the code like Christopher suggested, and added a test case for it.<br><br></div>the best,<br></div>thank you<br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-10-05 10:07 GMT+02:00 Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, 2015-10-03 at 11:35 -0700, Christopher Larson wrote:<br>
><br>
> On Mon, Sep 28, 2015 at 6:11 AM, Ming Liu <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>><br>
> wrote:<br>
> + if urldata.parm.get('subdir') != None:<br>
> + destdir = urldata.parm.get('subdir')<br>
> + "/" + destdir<br>
><br>
> If you really care about the difference between None and the empty<br>
> string, then this should be 'is not None', not '!= None', but most<br>
> likely you don't, in which case 'if urldata.parm.get('subdir')' is<br>
> sufficient, and cleaner. Also you do the parm.get() twice, it may be<br>
> better to store that in a variable.<br>
<br>
</span>Chris is correct, this patch needs tweaking. This area of the code also<br>
keeps seeing various issues so I'd like to ask that we add a test case<br>
for this in lib/bb/tests/ so we can ensure this doesn't regress in the<br>
future please.<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
<br>
</blockquote></div><br></div>