<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 10, 2016 at 10:54 AM, Humberto Ibarra <span dir="ltr">&lt;<a href="mailto:humberto.ibarra.lopez@intel.com" target="_blank">humberto.ibarra.lopez@intel.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":qk" class="a3s aXjCH">If an invalid layer is added to bblayers.<span class="il">conf</span>, the parsing of said file<br>
ends with a trace and an &quot;Unable to parse&quot; exception. This is not the<br>
ideal output, especially considering that we know exactly why this is failing.<br>
<br>
This patch checks if a layer <span class="il">conf</span> file exists before trying to parse it.<br>
If it does not, a clear and more concise message is send to the user.<br>
Otherwise, the parsing continues.<br>
<br>
[Yocto #9506]<br>
<br>
Signed-off-by: Humberto Ibarra &lt;<a href="mailto:humberto.ibarra.lopez@intel.com">humberto.ibarra.lopez@intel.com</a>&gt;<br>
---<br>
 <span class="il">bitbake</span>/lib/<span class="il">bb</span>/cookerdata.py | 6 +++++-<br>
 1 file changed, 5 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/<span class="il">bitbake</span>/lib/<span class="il">bb</span>/cookerdata.py b/<span class="il">bitbake</span>/lib/<span class="il">bb</span>/cookerdata.py<br>
index 50259a9..28f652e 100644<br>
--- a/<span class="il">bitbake</span>/lib/<span class="il">bb</span>/cookerdata.py<br>
+++ b/<span class="il">bitbake</span>/lib/<span class="il">bb</span>/cookerdata.py<br>
@@ -295,7 +295,11 @@ <span class="il">class</span> CookerDataBuilder(object):<br>
                 if layer.endswith(&#39;/&#39;):<br>
                     layer = layer.rstrip(&#39;/&#39;)<br>
                 data.setVar(&#39;LAYERDIR&#39;, layer)<br>
-                data = parse_config_file(os.path.join(layer, &quot;<span class="il">conf</span>&quot;, &quot;layer.<span class="il">conf</span>&quot;), data)<br>
+                layer_config_file = os.path.join(layer, &quot;<span class="il">conf</span>&quot;, &quot;layer.<span class="il">conf</span>&quot;)<br>
+                if not os.path.exists(layer_config_file):<br>
+                    parselog.critical(&quot;Unable to find layer configuration file: %s&quot; % layer_config_file)<br>
+                    sys.exit(1)<br>
+                data = parse_config_file(layer_config_file, data)</div></blockquote></div><br>This is potentially racy. Better to just try to open and catch the appropriate exception and check exc.errno for errno.ENOENT.<br>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>