<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 12, 2016 at 2:56 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":z3" class="a3s aXjCH">The string formatting wasn't correct and we should exit if we hit<br>
errors here similar to the other exception handlers.<br>
<br>
Signed-off-by: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>><br>
<br>
diff --git a/lib/<span class="il">bb</span>/cookerdata.py b/lib/<span class="il">bb</span>/cookerdata.py<br>
index 50259a9..fba95af 100644<br>
--- a/lib/<span class="il">bb</span>/cookerdata.py<br>
+++ b/lib/<span class="il">bb</span>/cookerdata.py<br>
@@ -192,7 +192,8 @@ def catch_parse_error(func):<br>
fn, _, _, _ = traceback.extract_tb(tb, 1)[0]<br>
if not fn.startswith(bbdir):<br>
break<br>
- parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb))<br>
+ parselog.critical("Unable to parse %s" % fn, exc_info=(exc_class, exc, tb))<br>
+ sys.exit(1)</div></blockquote></div><br>The python logging module supports passing the % format values as arguments, you don't have to format the string at call time. What was the error here?<br>-- <br><div class="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>