<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 6:46 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, 2016-08-15 at 10:16 -0700, Christopher Larson wrote:<br>
><br>
> On Mon, Aug 15, 2016 at 9:58 AM, Richard Purdie <<br>
> <a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@<wbr>linuxfoundation.org</a>> wrote:<br>
> > + if w in self.rq.worker:<br>
> > + name = "Worker"<br>
> > + elif w in self.rq.fakeworker:<br>
> > + name = "Fakeroot"<br>
> ><br>
> The concept seems sound, but there's still a fair bit of handling<br>
> which is do this thing for workers and that thing for fake workers,<br>
> makes me think we might want to split out objects to bind the<br>
> workers, their names, and their logic.<br>
<br>
</span>I agree and there is certainly room for improvement. I think the patch<br>
as it stands is probably a good first step and there are more that can<br>
be made on top of it, I'm open to them or may get around to it myself<br>
eventually if nobody else does. Part of the trouble I've had in doing<br>
this is not to get distracted from the multi-config work which<br>
necessitated it in the first place!</blockquote></div><br>Agreed. This is a step in the right direction.<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Christopher Larson<br>clarson at kergoth dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div>
</div></div>