<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 16, 2016 at 1:01 PM, Christopher Larson <span dir="ltr"><<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="gmail-"><div class="gmail_quote">On Fri, Sep 16, 2016 at 1:00 PM, Christopher Larson <span dir="ltr"><<a href="mailto:kergoth@gmail.com" target="_blank">kergoth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>From: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>><br>
<br>
We want any exceptions raised by the TaskStarted event handlers to be caught<br>
rather than unconditionally hitting the exception formatting + traceback in<br>
exec_task, otherwise we can't cleanly exit the task with a nice message from<br>
such a handler.<br>
<br>
This is done via a separate try/catch block, to avoid firing TaskFailed if all<br>
the TaskStarted event handlers didn't complete, otherwise the bitbake UIs get<br>
unhappy.<br>
<br>
Signed-off-by: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>></div></blockquote></div><br></span>This supercedes 'bb.build: in _exec_task, catch BBHandledException’.<br></blockquote><div><br></div><div>Sigh, copy/paste error. This supercedes 'bb.build: in _exec_task, move TaskStarted into try/except’. We want this and the BBHandledException patch both applied. I’ll just send a v2 to avoid confusion :)</div></div>-- <br><div class="gmail_signature"><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Maintainer - Tslib<br>Senior Software Engineer, Mentor Graphics</div></div>
</div></div>