<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 09/28/2016 12:12 PM, Christopher
      Larson wrote:<br>
    </div>
    <blockquote
cite="mid:CABcZANnYrgzeU22zQeHzsSePGF2-diaVUY_qjNe9vk3POCYyQA@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Wed, Sep 28, 2016 at 8:25 AM,
            akuster <span dir="ltr">&lt;<a moz-do-not-send="true"
                href="mailto:akuster@mvista.com" target="_blank">akuster@mvista.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"><span
                class="">On 09/28/2016 08:14 AM, Richard Purdie wrote:<br>
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  On Wed, 2016-09-28 at 08:06 -0700, Armin Kuster wrote:<br>
                  <blockquote class="gmail_quote" style="margin:0 0 0
                    .8ex;border-left:1px #ccc solid;padding-left:1ex">
                    From: Richard Purdie &lt;<a moz-do-not-send="true"
                      href="mailto:richard.purdie@linuxfoundation.org"
                      target="_blank">richard.purdie@linuxfoundatio<wbr>n.org</a>&gt;<br>
                    <br>
                    "hash() is randomised by default each time you start
                    a new instance<br>
                    of<br>
                    recent<br>
                    versions (Python3.3+) to prevent dictionary
                    insertion DOS attacks"<br>
                    <br>
                    which means we need to use hashlib.md5 to get
                    consistent values for<br>
                    the codeparser cache under python 3. Prior to this,
                    the codeparser<br>
                    cache was effectively useless under python3 as shown
                    by performance<br>
                    regressions.<br>
                    <br>
                    Signed-off-by: Richard Purdie &lt;<a
                      moz-do-not-send="true"
                      href="mailto:richard.purdie@linuxfoundation.org"
                      target="_blank">richard.purdie@linuxfoundatio<wbr>n.org</a>&gt;<br>
                    (cherry picked from commit
                    12d43cf45ba48e3587392f15315d92<wbr>a1a53482ef)<br>
                    <br>
                    We kept running into an issue where shell scripts
                    were not<br>
                    getting generated on 32bit hosts. It seemed to be
                    caused by this<br>
                    code.<br>
                  </blockquote>
                  I'm puzzled. This patch is in master. I'm therefore
                  assuming you're<br>
                  suggesting this for 1.30 but it doesn't say that
                  anywhere.<br>
                </blockquote>
                <br>
              </span>
              We made a similar change in our bitbake sources for 1.28
              which needed to be submitted per the Yocto compatible
              requirements.   I could have sent that one but then you
              might have said "Hey, this looks like the one in Master,
              why are you not using that one?".   I personally like to
              reference upstream official fixes than hand crafted ones
              that achieve the same result. I can send you the one we
              did if you want.</blockquote>
          </div>
          <br>
          I think the problem is you didn’t actually say what
          version/branch you wanted it applied to, not which commit the
          patch references..<br>
        </div>
      </div>
    </blockquote>
    oh.. I did didn't I .  that was lame. apologies.<br>
    <br>
    I can resent to add version to the subject.<br>
    <br>
    -armin<br>
    <blockquote
cite="mid:CABcZANnYrgzeU22zQeHzsSePGF2-diaVUY_qjNe9vk3POCYyQA@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div class="gmail_extra">-- <br>
          <div class="gmail_signature" data-smartmail="gmail_signature">Christopher
            Larson<br>
            clarson at kergoth dot com<br>
            Founder - BitBake, OpenEmbedded, OpenZaurus<br>
            Maintainer - Tslib<br>
            Senior Software Engineer, Mentor Graphics</div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>