<div dir="ltr">Thank you for the feedback!<div><br></div><div>I've added lines to check $OE_PAGER and $PAGER, such that `PAGER=cat bitbake -e` effectively disables pagination.</div><div><br></div><div>Regarding the option '--paginate', would it capture output from whatever command has run? I'm not sure how to capture stdout at such a scope.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 20, 2017 at 6:39 AM, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="SV" link="blue" vlink="purple">
<div class="m_-2171653402677448379WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">Basically, this change needs to be aware of the destination for the output. If it is a tty, then it is fine to output
to a viewer such as less, but otherwise it should go to stdout as before. This should of course not be hardcoded, but use environment variables, e.g., $OE_PAGER || $PAGER || less (inspired by git_pager() in the git source). You should also not expect that
everyone wants the options you have used for less. Looking again at how git handles this, they use “LESS=FRX <command>” if the $LESS environment variable is not set, and does not modify it if it is set. You also want to add options such as --paginate and --no-pager
(yet again inspired by git) to bitbake.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">All in all, look at and be inspired by how git handles pagers, they have this pretty well covered.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634">//Peter<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#943634"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@lists.<wbr>openembedded.org</a> [mailto:<a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@<wbr>lists.openembedded.org</a>]
<b>On Behalf Of </b>Burton, Ross<br>
<b>Sent:</b> den 20 juni 2017 12:06<br>
<b>To:</b> Diana Thayer <<a href="mailto:garbados@gmail.com" target="_blank">garbados@gmail.com</a>><br>
<b>Cc:</b> bitbake-devel <<a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.<wbr>openembedded.org</a>><br>
<b>Subject:</b> Re: [bitbake-devel] [PATCH] bitbake : Paginate 'bitbake -e' using less.<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 20 June 2017 at 05:54, Diana Thayer <<a href="mailto:garbados@gmail.com" target="_blank">garbados@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div id="m_-2171653402677448379:9ou">
<p class="MsoNormal">+ pager = subprocess.Popen(['less', '-F', '-R', '-S', '-X', '-K'],<br>
+ stdin=subprocess.PIPE,<br>
+ stdout=sys.stdout,<br>
+ universal_newlines=True)<u></u><u></u></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><br>
What if I'm piping bitbake -e though grep or into a file already?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Ross<u></u><u></u></p>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>