<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 24, 2017 at 2:43 PM, Christopher Larson <span dir="ltr"><<a href="mailto:kergoth@gmail.com" target="_blank">kergoth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><span class="gmail-">On Wed, Feb 3, 2016 at 9:29 AM, Felipe F. Tonello <span dir="ltr"><<a href="mailto:eu@felipetonello.com" target="_blank">eu@felipetonello.com</a>></span> wrote:<br></span><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">This fix a problem when checking out a commit that changes the submodules<br>
previously checkout.<br>
<br>
Example:<br>
Recipe uses branch A and then it updates to use branch B, but branch B has<br>
different submodules dependencies then what branch A previously had.<br>
<br>
Signed-off-by: Felipe F. Tonello <<a href="mailto:eu@felipetonello.com" target="_blank">eu@felipetonello.com</a>><br></blockquote><div><br></div></span><div>This completely broke the gitsm fetcher behavior. It no longer uses the previously fetched submodules from DL_DIR at all, instead the submodule update is re-cloning them from upstream in do_unpack, violating our conventions. Git checkout isn’t going to magically copy the existing fetched submodules from DL_DIR.</div></div></div></div></blockquote><div><br></div><div>Apologies for the harsh tone here, but clearly we should fix this differently. <a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=11830">https://bugzilla.yoctoproject.org/show_bug.cgi?id=11830</a> has been opened for this. It’ll be difficult to add a good unit test to catch this problem without using either a VM or containers to physically cut network connectivity. I’m going to propose a future bitbake enhancement to use namespaces to prevent network connectivity from non-fetch tasks.</div></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>
</div></div>