<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 23, 2017 at 8:01 AM, Christopher Larson <span dir="ltr"><<a href="mailto:kergoth@gmail.com" target="_blank">kergoth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="">On Wed, Aug 23, 2017 at 3:22 AM, Richard Purdie <span dir="ltr"><<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@<wbr>linuxfoundation.org</a>></span> wrote:<br></span><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_8893467195293992359HOEnZb"><div class="m_8893467195293992359h5">On Mon, 2017-08-21 at 21:57 +0500, Christopher Larson wrote:<br>
> From: Christopher Larson <<a href="mailto:chris_larson@mentor.com" target="_blank">chris_larson@mentor.com</a>><br>
><br>
> Revert "fetch2/gitsm: Fix when repository change submodules"<br>
><br>
> This reverts commit 12f6c0651af8bd5d6efb751690571c<wbr>f2fcd3eeb0.</div></div></blockquote></span><div>[…] </div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_8893467195293992359HOEnZb"><div class="m_8893467195293992359h5"><span style="color:rgb(34,34,34)">2017-08-23 11:20:14,819 - oe-selftest - INFO - Ran 1 test in 33.385s</span><br></div></div>
2017-08-23 11:20:14,819 - oe-selftest - INFO - FAILED<br>
2017-08-23 11:20:14,819 - oe-selftest - INFO - (failures=1)<br>
2017-08-23 11:20:14,824 - oe-selftest - INFO - RESULTS:<br>
2017-08-23 11:20:14,824 - oe-selftest - INFO - RESULTS - devtool.DevtoolTests.test_devt<wbr>ool_add_fetch_git - Testcase 1161: FAILED<br>
2017-08-23 11:20:14,824 - oe-selftest - INFO - SUMMARY:<br>
2017-08-23 11:20:14,824 - oe-selftest - INFO - oe-selftest () - Ran 1 test in 33.391s<br>
2017-08-23 11:20:14,824 - oe-selftest - INFO - oe-selftest - FAIL - Required tests failed<br>
<br>
Could you take a look at that test case and see what the issue is please?<br></blockquote><div><br></div></span><div>Will do, thanks, sorry about that. I ran the bitbake selftests, but didn’t think to re-run the oe selftests. *eyeroll* </div></div></div></div></blockquote><div><br></div><div> </div></div>This is uglier than I had been thinking. If the upstream url for an existing module changes between srcrevs or branches, we’re in trouble, since the modules/ dir in clonedir won’t line up with .gitmodules. I was thinking about adding a needs_update() to GitSM to check for the case where it doesn’t match up, but then if multiple recipes need different sets of modules for the same clonedir at the same time, they’d both run download() and first one would switch to one configuration, then the other would switch back..</div><div class="gmail_extra"><br></div><div class="gmail_extra">The perils of using a single directory in a single clone for multiple possible sets of modules and revs.. I don’t think it’s worth trying to handle this with a stopgap measure, best to just punt on this for this release and pursue the rewrite of gitsm after the release. Feel free to drop these patches. Thanks.<br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>
</div></div>