<div dir="ltr">Just saw that Richard Purdie backported Daniel Lublin's original commit to 1.26 and 1.28 (<a href="http://git.openembedded.org/bitbake/commit/?h=1.26&id=edd90cd858da5da564e9849ebc0849a8a8173d4f" target="_blank">edd90cd858da5da564e9849ebc084<wbr>9a8a8173d4f</a> and <a href="http://git.openembedded.org/bitbake/commit/?h=1.28&id=0d80cacb2b84ee059cee3caf8a5968033b9ce3c5" target="_blank">0d80cacb2b84ee059cee3caf8a<wbr>5968033b9ce3c5</a>). I noticed it was pushed upstream to yocto-poky fido and jethro as well. I did a fresh checkout of yocto-poky fido and jethro and got both to build past that error out of the box. Thanks to Richard and Daniel and everyone else!</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 29, 2018 at 10:43 AM, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="SV" link="blue" vlink="purple">
<div class="m_-7694966196785305973WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#943634">One way to create and send the patch is:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-family:Consolas;color:#943634">git cherry-pick 1679188f9c55c615cae780f2b5e685<wbr>2dea9cf2ec # Assuming you are in the bitbake repository, not poky<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-family:Consolas;color:#943634">git commit --amend # To add your Signed-off-by footer<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-family:Consolas;color:#943634">git format-patch --subject-prefix='jethro][<wbr>PATCH' 'HEAD^..HEAD'<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-family:Consolas;color:#943634">git send-email --to=<a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.<wbr>openembedded.org</a> --confirm=always --no-chain-reply-to --suppress-cc=all 000*<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634">//Peter<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@lists.<wbr>openembedded.org</a> [mailto:<a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@<wbr>lists.openembedded.org</a>]
<b>On Behalf Of </b>Soemoe Aung<br>
<b>Sent:</b> den 28 mars 2018 18:47<br>
<b>To:</b> Ola x Nilsson <<a href="mailto:Ola.x.Nilsson@axis.com" target="_blank">Ola.x.Nilsson@axis.com</a>><br>
<b>Cc:</b> <a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.<wbr>openembedded.org</a><br>
<b>Subject:</b> Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as well. My change literally took the html5lib file from 1.30 and copied it to the file in 1.26
and submitted it as a patch. Apologies if this was the wrong way to go about this.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">What are the steps to backport this change to 1.26 and 1.28 (and also to send these changes upstream to yocto-poky)? Is there anything I need to do?<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <<a href="mailto:ola.x.nilsson@axis.com" target="_blank">ola.x.nilsson@axis.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">This has already been fixed on a few branches with<br>
<br>
bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8<br>
<br>
It might be better to backport that where needed.<br>
<br>
--<br>
Ola Nilsson<br>
______________________________<wbr>__________<br>
From: <a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@lists.<wbr>openembedded.org</a> <<a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@lists.<wbr>openembedded.org</a>> on behalf of Soemoe Aung <<a href="mailto:soemoe.a@gmail.com" target="_blank">soemoe.a@gmail.com</a>><br>
Sent: Tuesday, March 27, 2018 23:15<br>
To: <a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.<wbr>openembedded.org</a><br>
Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib
is indeed different there.<br>
<br>
yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also
has the issue fixed in the bitbake repo.<br>
<br>
I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky
fido and jethro branches?<br>
<br>
Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky.<br>
<br>
The following changes since commit ea6d21066a7cce2fef08ad66287170<wbr>c5995bb1e2:<br>
<br>
bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000)<br>
<br>
are available in the Git repository at:<br>
<br>
git://<a href="http://push.yoctoproject.org/poky-contrib" target="_blank">push.yoctoproject.org/<wbr>poky-contrib</a> saung/bitbake-html5lib<br>
<br>
Soemoe Aung (2):<br>
fix build error in included html5lib in bitbake<br>
fix html5lib fix to be the same as in the krogoth branch<br>
<br>
bitbake/lib/bs4/builder/_<wbr>html5lib.py | 17 ++++++++++++-----<br>
1 file changed, 12 insertions(+), 5 deletions(-)<br>
<br>
--<br>
2.17.0.rc0.231.g781580f067-<wbr>goog<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">--<br>
______________________________<wbr>_________________<br>
bitbake-devel mailing list<br>
<a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/bitbake-devel" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/bitbake-devel</a><br>
<span class="m_-7694966196785305973hoenzb"><span style="color:#888888">--</span></span><span style="color:#888888"><br>
<span class="m_-7694966196785305973hoenzb">______________________________<wbr>_________________</span><br>
<span class="m_-7694966196785305973hoenzb">bitbake-devel mailing list</span><br>
<span class="m_-7694966196785305973hoenzb"><a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.<wbr>openembedded.org</a></span><br>
<span class="m_-7694966196785305973hoenzb"><a href="http://lists.openembedded.org/mailman/listinfo/bitbake-devel" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/bitbake-devel</a></span></span><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>