<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
All runQueueEvents are for specific task - its __init__ function has
task parameter and it reads more parameters from it (taskname,
taskfile and taskhash).<br>
sceneQueueComplete event is fired when all tasks are complete, so
for me it isn't a runQueueEvent, so it isn't sceneQueueEvent too.<br>
Passing None as task is not an option, because
runQueueEvent.__init__ will fail.<br>
<div class="moz-signature">
<div style="padding:0px 0px; margin:0 0 0px 0;
font-family:Arial,sans-serif; color:#26437e; font-size:12px;
text-align:left; line-height:18px;">
<br>
</div>
</div>
<div class="moz-cite-prefix">On 29.10.2018 19:05, Christopher Larson
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CABcZANk7p-Fefxi8y2P2GHa22Y=RifxA4VnWAAyGxN2vPP8pJA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">This looks wrong. Fix the __init__ instead.</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Mon, Oct 29, 2018 at 10:22 AM Tomasz
Meresiński <<a href="mailto:tomasz.meresinski@comarch.pl"
moz-do-not-send="true">tomasz.meresinski@comarch.pl</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">__init__
method initialized bb.event.Event not sceneQueueEvent.<br>
Change base class to bb.event.Event.<br>
<br>
Signed-off-by: Tomasz Meresiński <<a
href="mailto:tomasz.meresinski@comarch.com" target="_blank"
moz-do-not-send="true">tomasz.meresinski@comarch.com</a>><br>
---<br>
lib/bb/runqueue.py | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py<br>
index 9ce06c40..e138a5c2 100644<br>
--- a/lib/bb/runqueue.py<br>
+++ b/lib/bb/runqueue.py<br>
@@ -2615,7 +2615,7 @@ class
sceneQueueTaskFailed(sceneQueueEvent):<br>
def __str__(self):<br>
return "Setscene task (%s) failed with exit code '%s'
- real task will be run instead" % (self.taskstring,
self.exitcode)<br>
<br>
-class sceneQueueComplete(sceneQueueEvent):<br>
+class sceneQueueComplete(bb.event.Event):<br>
"""<br>
Event when all the sceneQueue tasks are complete<br>
"""<br>
-- <br>
2.17.1<br>
<br>
-- <br>
_______________________________________________<br>
bitbake-devel mailing list<br>
<a href="mailto:bitbake-devel@lists.openembedded.org"
target="_blank" moz-do-not-send="true">bitbake-devel@lists.openembedded.org</a><br>
<a
href="http://lists.openembedded.org/mailman/listinfo/bitbake-devel"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.openembedded.org/mailman/listinfo/bitbake-devel</a><br>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">Christopher Larson<br>
kergoth at gmail dot com<br>
Founder - BitBake, OpenEmbedded, OpenZaurus<br>
Senior Software Engineer, Mentor Graphics</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>