<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi, Mark:<div><br></div><div>I could reproduce the error reported by Stefan, on the tip:</div><div>...</div><div><div>commit 8c8ecec2a722bc2885e2648d41ac8df07bdf660d</div><div>Author: Mark Hatle <<a href="mailto:mark.hatle@windriver.com">mark.hatle@windriver.com</a>></div><div>Date: Wed Jan 23 10:28:18 2019 -0500</div><div><br></div><div> gitsmy.py: Fix unpack of submodules of submodules</div></div><div>...</div><div><br></div><div><br></div><div>seems GitSM does not handle recursive submodules.</div><div><br></div><div>in my aktualizr/1.0+gitAUTOINC+d00d1a04cc-7/git/.git/config:</div><div>...</div><div>[submodule "tests/tuf-test-vectors"]</div><div> url = /mnt/oe/downloads/git2/github.com.advancedtelematic.tuf-test-vectors.</div><div>[submodule "partial/extern/isotp-c"]</div><div> url = /mnt/oe/downloads/git2/github.com.advancedtelematic.isotp-c.git</div><div>[submodule "third_party/HdrHistogram_c"]</div><div> url = /mnt/oe/downloads/git2/github.com.HdrHistogram.HdrHistogram_c</div><div>[submodule "third_party/googletest"]</div><div> url = /mnt/oe/downloads/git2/github.com.google.googletest.git </div><div>...</div><div><br></div><div>in which, /mnt/oe/downloads/git2/github.com.advancedtelematic.isotp-c.git has its own submodule, </div><div><br></div><div>aktualizr/1.0+gitAUTOINC+d00d1a04cc-7/git/partial/extern/isotp-c/.gitmodules<br></div><div>...</div><div><div>[submodule "deps/bitfield-c"]</div><div> path = deps/bitfield-c</div><div> url = <a href="https://github.com/advancedtelematic/bitfield-c.git">https://github.com/advancedtelematic/bitfield-c.git</a></div></div><div>...</div><div><br></div><div>but that recursive submodule is fetched but not unpacked.</div><div><br></div><div>the best,</div><div>thank you</div></div></div></div></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Patrick Vacek <<a href="mailto:patrickvacek@gmail.com">patrickvacek@gmail.com</a>> 於 2019年1月26日 週六 下午1:07寫道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">On Sat, Jan 26, 2019 at 11:15 AM Stefan Agner <<a href="mailto:stefan@agner.ch" target="_blank">stefan@agner.ch</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> So it seems to be that something in the recipe was expecting semi-broken<br>
> behavior.. and its actually a recipe problem.<br>
<br>
Agreed, in this case we need to fix the recipe.<br></blockquote><div>Sorry, I must be missing something. What might be wrong with the recipe? Is there more that needs to be specified than a SRCREV and a branch? As far as I understand git, it keeps track of the submodules, so I don't know what other information there would be to provide. The reason this particular case is difficult is because there are recursive submodules. When we build aktualizr, we have to be careful to specify that. See <a href="https://github.com/advancedtelematic/aktualizr#building" target="_blank">https://github.com/advancedtelematic/aktualizr#building</a>:</div><div><br></div><div><div>git submodule update --init --recursive</div></div><div><br></div><div>Thanks,</div><div>Patrick</div></div></div></div></div>
</blockquote></div>