<div dir="ltr">This should really use shlex.split rather than str.split to handle quoting, etc.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 7, 2019 at 9:56 AM Joshua Watt &lt;<a href="mailto:jpewhacker@gmail.com">jpewhacker@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Changes FAKEROOTCMD so that it can accept additional arguments to pass<br>
to the fakeroot implementation instead of being treated as a simple<br>
command<br>
<br>
Signed-off-by: Joshua Watt &lt;<a href="mailto:JPEWhacker@gmail.com" target="_blank">JPEWhacker@gmail.com</a>&gt;<br>
---<br>
 bitbake/lib/bb/runqueue.py | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py<br>
index 6002ccf06a8..56b8319528c 100644<br>
--- a/bitbake/lib/bb/runqueue.py<br>
+++ b/bitbake/lib/bb/runqueue.py<br>
@@ -1221,12 +1221,12 @@ class RunQueue:<br>
         if fakeroot:<br>
             magic = magic + &quot;beef&quot;<br>
             mcdata = self.cooker.databuilder.mcdata[mc]<br>
-            fakerootcmd = mcdata.getVar(&quot;FAKEROOTCMD&quot;)<br>
+            fakerootcmd = mcdata.getVar(&quot;FAKEROOTCMD&quot;).split()<br>
             fakerootenv = (mcdata.getVar(&quot;FAKEROOTBASEENV&quot;) or &quot;&quot;).split()<br>
             env = os.environ.copy()<br>
             for key, value in (var.split(&#39;=&#39;) for var in fakerootenv):<br>
                 env[key] = value<br>
-            worker = subprocess.Popen([fakerootcmd, &quot;bitbake-worker&quot;, magic], stdout=subprocess.PIPE, stdin=subprocess.PIPE, env=env)<br>
+            worker = subprocess.Popen(fakerootcmd + [&quot;bitbake-worker&quot;, magic], stdout=subprocess.PIPE, stdin=subprocess.PIPE, env=env)<br>
         else:<br>
             worker = subprocess.Popen([&quot;bitbake-worker&quot;, magic], stdout=subprocess.PIPE, stdin=subprocess.PIPE)<br>
         bb.utils.nonblockingfd(worker.stdout)<br>
-- <br>
2.20.1<br>
<br>
-- <br>
_______________________________________________<br>
bitbake-devel mailing list<br>
<a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/bitbake-devel" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/bitbake-devel</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>