<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">I just got few thousands of warnings thanks to this, they might be legitimate as write_bom_data and write_abi_xml_data are our own tasks added in <a href="https://github.com/webosose/meta-webosose/blob/master/meta-webos/classes/webos_base.bbclass">https://github.com/webosose/meta-webosose/blob/master/meta-webos/classes/webos_base.bbclass</a> very long time ago (based on fetchall task which was added in 2006 :)) - there might be better way to add them now, I'll check how to do it better or else I might need to disable this warning locally.</div><div dir="ltr"><br></div><div>Based on "utility-tasks: Drop fetchall and checkuriall tasks" I guess the right way to do the same now will be to convert our scripts to call it with --runall.</div><div dir="ltr"><br></div><div dir="ltr">It's pity that the warning is shown repeatedly.</div><div dir="ltr"><br></div><div dir="ltr"><div dir="ltr">grep -c WARNING:.*dependent.task BUILD/log/cooker/m16p3/console-latest.log </div><div dir="ltr">30409</div><div><br></div><div>and that was only very small build not even finished yet:</div><div>Currently 7 running tasks (1142 of 2514)</div><div><br></div><div>..</div><div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task write_bom_data does not exist</div><div>WARNING: cross-localedef-native: dependent task write_abi_xml_data does not exist</div><div>WARNING: autoconf-archive-native: dependent task do_deploy does not exist</div><div>WARNING: autoconf-archive-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: autoconf-archive-native: dependent task do_deploy does not exist</div><div>WARNING: autoconf-archive-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: autoconf-archive-native: dependent task write_bom_data does not exist</div><div>WARNING: autoconf-archive-native: dependent task write_abi_xml_data does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task write_bom_data does not exist</div><div>WARNING: cross-localedef-native: dependent task write_abi_xml_data does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task write_bom_data does not exist</div><div>WARNING: cross-localedef-native: dependent task write_abi_xml_data does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task do_deploy does not exist</div><div>WARNING: cross-localedef-native: dependent task do_package_write_ipk does not exist</div><div>WARNING: cross-localedef-native: dependent task write_bom_data does not exist</div><div>WARNING: cross-localedef-native: dependent task write_abi_xml_data does not exist</div></div><div>..</div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 26, 2019 at 4:49 AM Robert Yang <<a href="mailto:liezhi.yang@windriver.com">liezhi.yang@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 4/25/19 6:50 PM, Richard Purdie wrote:<br>
> On Thu, 2019-04-25 at 18:01 +0800, Robert Yang wrote:<br>
>> The following command is incorrect, but was ignored silently, that may suprise<br>
>> users:<br>
>><br>
>> addtask task after task_not_existed<br>
>><br>
>> This patch can check and warn for it. It would be better to also check "before"<br>
>> tasks, but there is no easier way to do it.<br>
>><br>
>> [YOCTO #13282]<br>
>><br>
>> Signed-off-by: Robert Yang <<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>><br>
>> ---<br>
>> bitbake/lib/bb/build.py | 3 +++<br>
>> 1 file changed, 3 insertions(+)<br>
>><br>
>> diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py<br>
>> index 7571421..861e9a9 100644<br>
>> --- a/bitbake/lib/bb/build.py<br>
>> +++ b/bitbake/lib/bb/build.py<br>
>> @@ -815,6 +815,9 @@ def add_tasks(tasklist, d):<br>
>> task_deps['parents'][task] = []<br>
>> if 'deps' in flags:<br>
>> for dep in flags['deps']:<br>
>> + # Check and warn for "addtask task after foo" while foo does not exist<br>
>> + if not dep in tasklist:<br>
>> + bb.warn('%s: dependent task %s does not exist!' % (d.getVar('PN'), dep))<br>
>> dep = d.expand(dep)<br>
>> task_deps['parents'][task].append(dep)<br>
> <br>
> I can't help wonder if this change has races, depending on the order of<br>
> the addtask and deltask expressions. Do most layers parse cleanly with<br>
> this?<br>
<br>
The bb.build.add_tasks() is only called by ast.py's finalize(), I think that<br>
everything should be ready in finalize stage, and there should be no races.<br>
I tested this with meta-oe, python perl, selinux and others, didn't see<br>
any problems (unless I depended on an invalid task).<br>
<br>
> <br>
> At one point bitbake did support "floating" invalid tasks, I can't<br>
> remember if we changed that or not though.<br>
<br>
This warning is good for checking typos during development, I think that<br>
user can call "bb.build.addtask()" dynamically in a function to fix the warning<br>
for floating tasks?<br>
<br>
// Robert<br>
<br>
> <br>
> Cheers,<br>
> <br>
> Richard<br>
> <br>
> <br>
-- <br>
_______________________________________________<br>
bitbake-devel mailing list<br>
<a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/bitbake-devel" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/bitbake-devel</a><br>
</blockquote></div>