<div dir="ltr"><div>Regarding some comments in PATCHv2 where default value was set [1], I agree that this patch will be better and then set default value</div><div>in oe-core.</div><div><br></div><div>[1] <a href="http://lists.openembedded.org/pipermail/bitbake-devel/2019-November/020519.html">http://lists.openembedded.org/pipermail/bitbake-devel/2019-November/020519.html</a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 14 Nov 2019 at 12:08, Anibal Limon <<a href="mailto:anibal.limon@linaro.org">anibal.limon@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 14 Nov 2019 at 12:07, Anibal Limon <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 14 Nov 2019 at 10:54, Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> -----Original Message-----<br>
> From: <a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank">bitbake-devel-bounces@lists.openembedded.org</a> <bitbake-devel-<br>
> <a href="mailto:bounces@lists.openembedded.org" target="_blank">bounces@lists.openembedded.org</a>> On Behalf Of Khem Raj<br>
> Sent: den 14 november 2019 03:55<br>
> To: Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>><br>
> Cc: bitbake-devel <<a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank">bitbake-devel@lists.openembedded.org</a>><br>
> Subject: Re: [bitbake-devel] [PATCH] lib/bb: Add<br>
> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories<br>
> <br>
> On Wed, Nov 13, 2019 at 3:23 PM Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>><br>
> wrote:<br>
> ><br>
> > The new BB_SIGNATURE_LOCAL_DIRS_EXCLUDE allows you to specify a list<br>
> > of directories to exclude when making taskhash, our specific case<br>
> > is using SRC_URI that points local VCS directory.<br>
> ><br>
> > In OE-Core this variable could be set by default to:<br>
> ><br>
> > BB_SIGNATURE_LOCAL_DIRS_EXCLUDE = ".cvs .git .svn"<br>
<br>
That should be:<br>
<br>
BB_SIGNATURE_LOCAL_DIRS_EXCLUDE = "CVS .git .svn"<br></blockquote><div><br></div><div>So I will change to,</div><div><br></div><div>+ self.localdirsexclude = (data.getVar("BB_SIGNATURE_LOCAL_DIRS_EXCLUDE") or "CVS .git .svn").split()<br></div><div><br></div><div>Any other directory to add it?</div></div></div></blockquote><div><br></div><div>Replying myself...</div><div><br></div><div>What about add all VCS directories that we support in fetcher.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Cheers,</div><div>Anibal</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> I like the approach. perhaps a sane default would be nice.<br>
<br>
//Peter<br>
<br>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div></div>