<div dir="auto">Hi, any update?<div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Anibal</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El lun., 18 de nov. de 2019 09:22, Anibal Limon <<a href="mailto:anibal.limon@linaro.org">anibal.limon@linaro.org</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 15 Nov 2019 at 11:12, Mark Hatle <<a href="mailto:mark.hatle@kernel.crashing.org" target="_blank" rel="noreferrer">mark.hatle@kernel.crashing.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 11/15/19 10:29 AM, Peter Kjellerstedt wrote:<br>
>> -----Original Message-----<br>
>> From: <a href="mailto:bitbake-devel-bounces@lists.openembedded.org" target="_blank" rel="noreferrer">bitbake-devel-bounces@lists.openembedded.org</a> <bitbake-devel-<br>
>> <a href="mailto:bounces@lists.openembedded.org" target="_blank" rel="noreferrer">bounces@lists.openembedded.org</a>> On Behalf Of Aníbal Limón<br>
>> Sent: den 15 november 2019 15:47<br>
>> To: <a href="mailto:bitbake-devel@lists.openembedded.org" target="_blank" rel="noreferrer">bitbake-devel@lists.openembedded.org</a><br>
>> Subject: [bitbake-devel] [PATCHv2] lib/bb: Add<br>
>> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE to speed-up taskhash on directories<br>
>><br>
>> The new BB_SIGNATURE_LOCAL_DIRS_EXCLUDE allows you to specify a list<br>
>> of directories to exclude when making taskhash, our specific case<br>
>> is using SRC_URI that points local VCS directory.<br>
>><br>
>> Use bb.fetch.module to set default to: "CVS .bzr .git .hg .osc .p4 .repo<br>
>> .svn"<br>
>><br>
>> Signed-off-by: Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank" rel="noreferrer">anibal.limon@linaro.org</a>><br>
>> ---<br>
>> lib/bb/checksum.py | 5 +++--<br>
>> lib/bb/fetch2/__init__.py | 4 ++--<br>
>> lib/bb/siggen.py | 5 +++--<br>
>> 3 files changed, 8 insertions(+), 6 deletions(-)<br>
> <br>
> [cut]<br>
> <br>
>> --- a/lib/bb/siggen.py<br>
>> +++ b/lib/bb/siggen.py<br>
>> @@ -123,6 +123,7 @@ class SignatureGeneratorBasic(SignatureGenerator):<br>
>><br>
>> self.unihash_cache = bb.cache.SimpleCache("1")<br>
>> self.unitaskhashes = self.unihash_cache.init_cache(data, "bb_unihashes.dat", {})<br>
>> + self.localdirsexclude = (data.getVar("BB_SIGNATURE_LOCAL_DIRS_EXCLUDE") or "CVS .bzr .git .hg .osc .p4 .repo .svn").split()<br>
> <br>
> I don't like this construct, because if I do:<br>
> <br>
> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE_append = " some_dir"<br>
> <br>
> it means that all of a sudden the SCM directories listed above will no <br>
> longer be excluded since BB_SIGNATURE_LOCAL_DIRS_EXCLUDE will now be <br>
> defined, but only contain " some_dir". Isn't it better to add:<br>
> <br>
> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE ??= "CVS .bzr .git .hg .osc .p4 .repo .svn"<br>
<br>
I agree.. this really should be put into the bitbake.conf file in OE-core. (I'd<br>
also suggest adding it to the bitbake.conf file in bitbake itself, as an example.)<br>
<br>
--Mark<br>
<br>
> somewhere in OE-Core (and it can then also have a suitable <br>
> BB_SIGNATURE_LOCAL_DIRS_EXCLUDE[doc], though it seems BB_-variables <br>
> are only documented in meta/conf/documentation.conf)?<br>
> <br>
> Alternatively, to keep the list above within bitbake, make it two <br>
> variables, one for the list of directories above that is not really <br>
> intended to be modified, and one for additional directories (which <br>
> should still be documented in meta/conf/documentation.conf).<br></blockquote><div><br></div><div>For me it is fine if we set this variable in OE-Core with a default value to VCS directories this is covered by v1 PATCH, after merge I will send </div><div>a patch to OE-Core adding the default value.</div><div><br></div><div>Regards,</div><div>Anibal</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> <br>
> //Peter<br>
> <br>
</blockquote></div></div>
</blockquote></div>