[Openembedded-architecture] Consistent white-space indentation in metadata layers

[Martin Jansa]

On Wed, May 03, 2017 at 01:03:08PM -0400, Trevor Woerner wrote:
> On Wed 2017-05-03 @ 05:24:27 PM, Martin Jansa wrote:
> > It was proposed in the thread about that python indentation change:
> > http://lists.openembedded.org/pipermail/bitbake-devel/2012-July/002461.html
> > and a bit later I've sent a patch for meta-oe layers:
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090147.html
> > which was approved and merged by meta-oe maintainer at that time Koen
> > (also memeber of TSC at that time):
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090162.html
> > and Joe maintainer of meta-networking (also inside meta-oe respository):
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090181.html
> > another TSC member also approved it after the fact:
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090184.html
> > and another TSC member was at least aware of this change:
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090184.html
> 
> (just wanted to point out the last two links are the same)

Thanks for reading carefully, the first from last two should be:
http://lists.openembedded.org/pipermail/openembedded-devel/2013-April/090203.html
 
> *IF* we decide to adopt a strict policy (and I'm not taking or stating an
> opinion either way), in addition to updating the wiki pages discussing the
> style guide:
> 
> - Would it be possible to add "vim:" and "emacs:" lines at the top of every
>   file to help enforce the policy? I think it would make it easier for people
>   to follow any such style guide with less effort.

Once (and *IF*) it's approved we can easily update
http://git.openembedded.org/bitbake/tree/contrib/vim/syntax/bitbake.vim
to highlight every tab in .bb/.bbappend/.bbclass/.inc files because then
99,9% of the tabs in metadata will be incorrect.

I don't know what else you can (or want) enforce with "vim:" or "emacs:" tags,
but I would be open to that as well as people shouldn't be bothered with
boring things like this and should concentrate on more interesting
things.
 
> - Also, could the new patchtest analyzer be recruited to help enforce a guide?

I don't know the patchtest analyzer implementation, but enforcing
consistent policy must be easier to implement than the tool understanding
which lines are part of python or shell task.

Regards,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-architecture/attachments/20170503/32168276/attachment.sig>