[oe-commits] org.oe.dev sanity.bbclass: loop over required utilities

[mickeyl commit]

sanity.bbclass: loop over required utilities

Author: mickeyl at openembedded.org
Branch: org.openembedded.dev
Revision: 39cd1690a777f207066c9b69227892102446b741
ViewMTN: http://monotone.openembedded.org/revision.psp?id=39cd1690a777f207066c9b69227892102446b741
Files:
1
classes/sanity.bbclass
Diffs:

#
# mt diff -rbbeec593a06924cf37bd5ebaae5ba95b02dd3ca7 -r39cd1690a777f207066c9b69227892102446b741
#
# 
# 
# patch "classes/sanity.bbclass"
#  from [a54de34e76ba8d0e47d03f7bf019698eadfd9599]
#    to [c0a1f67ea35cb92d663011f913c4e38b0783a0d3]
# 
============================================================
--- classes/sanity.bbclass	a54de34e76ba8d0e47d03f7bf019698eadfd9599
+++ classes/sanity.bbclass	c0a1f67ea35cb92d663011f913c4e38b0783a0d3
@@ -82,24 +82,12 @@ def check_sanity(e):
 	if not check_app_exists('${BUILD_PREFIX}g++', e.data):
 		raise_sanity_error('C++ Host-Compiler is missing, please install one' )
 
-	if not check_app_exists('patch', e.data):
-		raise_sanity_error('Please install the patch utility, preferable GNU patch.')
+	required_utilities = "patch diffstat texi2html makeinfo cvs svn git bzip2 tar gzip"
 
-	if not check_app_exists('diffstat', e.data):
-		raise_sanity_error('Please install the diffstat utility')
+	for util in required_utilities.split():
+		if not check_app_exists( util, e.data ):
+			raise_sanity_error( "Please install the %s utility." )
 
-	if not check_app_exists('texi2html', e.data):
-		raise_sanity_error('Please install the texi2html binary')
-
-	if not check_app_exists('cvs', e.data):
-		raise_sanity_error('Please install the cvs utility')
-
-	if not check_app_exists('svn', e.data):
-		raise_sanity_error('Please install the svn utility')
-
-	if not check_app_exists('bzip2', e.data):
-		raise_sanity_error('Please install the bzip2 utility')
-
 	oes_bb_conf = data.getVar( 'OES_BITBAKE_CONF', e.data, True )
 	if not oes_bb_conf:
 		raise_sanity_error('You do not include OpenEmbeddeds version of conf/bitbake.conf')