[oe-commits] org.oe.dev classes/insane.bbclass: Run the first test of the insanity.bbclass

[freyther commit]

classes/insane.bbclass: Run the first test of the insanity.bbclass

Author: freyther at openembedded.org
Branch: org.openembedded.dev
Revision: 4377a1163151d096d9f0d73c5d35a5bdd66f76d8
ViewMTN: http://monotone.openembedded.org/revision.psp?id=4377a1163151d096d9f0d73c5d35a5bdd66f76d8
Files:
1
classes/insane.bbclass
Diffs:

#
# mt diff -r04bf1b8757bb8285e6281c258bb584f88b35118f -r4377a1163151d096d9f0d73c5d35a5bdd66f76d8
#
# 
# 
# patch "classes/insane.bbclass"
#  from [3ddb489acd4ee35e37e8d2b6dc7d868244fd6b5b]
#    to [1beaa5113861a2ad1554d156f391c37888cb8d66]
# 
============================================================
--- classes/insane.bbclass	3ddb489acd4ee35e37e8d2b6dc7d868244fd6b5b
+++ classes/insane.bbclass	1beaa5113861a2ad1554d156f391c37888cb8d66
@@ -1,4 +1,3 @@
-#
 # BB Class inspired by ebuild.sh
 #
 # This class will test files after installation for certain
@@ -23,19 +22,59 @@ PACKAGEFUNCS += " do_package_qa "
 PACKAGE_DEPENDS += "pax-utils-native"
 PACKAGEFUNCS += " do_package_qa "
 
-def package_qa_check_rpath(path):
+def package_qa_check_rpath(file,name):
+    """
+    Check for dangerous RPATHs
+    """
     pass
 
 def package_qa_check_devdbg(path, name):
+    """
+    Check for debug remains inside the binary or
+    non dev packages containing
+    """
+    if not "-dev" in name:
+        if path[-3:] == ".so":
+            bb.error("QA Issue: non dev package contains .so")
+
+    if not "-dbg" in name:
+        if path[-4:] == ".dbg":
+            bb.error("QA Issue: non debug package contains .dbg file")
+
+def package_qa_check_perm(path,name):
+    """
+    Check the permission of files
+    """
     pass
 
-def package_qa_check_perm(path):
+def package_qa_check_arch(path,name):
+    """
+    Check if archs are compatible
+    """
     pass
 
+def package_qa_check_pcla(path,name):
+    """
+    .pc and .la files should not point
+    """
+
 def package_qa_check_staged(path):
+    """
+    Check staged la and pc files for sanity
+      -e.g. installed being false
+    """
     pass
 
+# Walk over all files in a directory and call func
+def package_qa_walk(path, funcs, package):
+    import os
+    for root, dirs, files in os.walk(path):
+        for file in files:
+            path = os.path.join(root,file)
+            for func in funcs:
+                func(path, package)
 
+
 # The PACKAGE FUNC to scan each package
 python do_package_qa () {
     bb.note("DO PACKAGE QA")
@@ -49,9 +88,7 @@ python do_package_qa () {
     for package in packages.split():
         bb.note("Package: %s" % package)
         path = "%s/install/%s" % (workdir, package)
-        package_qa_check_rpath(path)
-        package_qa_check_devdbg(path,package)
-        package_qa_check_perm(path)
+        package_qa_walk(path, [package_qa_check_rpath, package_qa_check_devdbg, package_qa_check_perm, package_qa_check_arch], package)
 }
 
 
@@ -59,4 +96,6 @@ python do_qa_staging() {
 addtask qa_staging after do_populate_staging before do_build
 python do_qa_staging() {
     bb.note("Staged!")
+
+    package_qa_check_staged(bb.data.getVar('STAGING_DIR',d,True))
 }