[oe-commits] org.oe.dev classes/insane.bbclass: Make .la failures non-fatal the right way, split up the .la test in two parts

[freyther commit]

classes/insane.bbclass: Make .la failures non-fatal the right way, split up the .la test in two parts
    -We have a function that can decide if a failure is fatal, use that instead of
     setting sane = True.
    -Test for installed and workdir separately. This allows us to ignore a certain error
     class and complain on others.

Author: freyther at openembedded.org
Branch: org.openembedded.dev
Revision: ea1be019784707c691fa7f551d0b60a7ae6f81f1
ViewMTN: http://monotone.openembedded.org/revision/info/ea1be019784707c691fa7f551d0b60a7ae6f81f1
Files:
1
classes/insane.bbclass
Diffs:

#
# mt diff -r162ce9b1b0555dce176af50883807fbbee153a05 -rea1be019784707c691fa7f551d0b60a7ae6f81f1
#
# 
# 
# patch "classes/insane.bbclass"
#  from [bd019dba2556f00365f037430e350e115f4b9ab1]
#    to [966a68a540a5da659592f677d4ed3dd2d5282a22]
# 
============================================================
--- classes/insane.bbclass	bd019dba2556f00365f037430e350e115f4b9ab1
+++ classes/insane.bbclass	966a68a540a5da659592f677d4ed3dd2d5282a22
@@ -178,7 +178,7 @@ def package_qa_make_fatal_error(error_cl
 
     TODO: Load a whitelist of known errors
     """
-    if error_class == 0:
+    if error_class == 0 or error_class == 5:
         return False
     else:
         return True
@@ -339,14 +339,21 @@ def package_qa_check_staged(path,d):
             path = os.path.join(root,file)
             if file[-2:] == "la":
                 file_content = open(path).read()
-                if installed in file_content or workdir in file_content:
-                    bb.error("QA issue: %s failed sanity test (reference to workdir or installed)" % file )
+                if installed in file_content:
+                    bb.error("QA issue: %s failed sanity test (installed) in path %s" % \
+                             (file,root))
                     if package_qa_make_fatal_error( 5, "staging", path, d):
-                        sane = True
+                        sane = False
+                if workdir in file_content:
+                    bb.error("QA issue: %s failed sanity test (workdir) in path %s" % \
+                             (file,root))
+                    if package_qa_make_fatal_error( 5, "staging", path, d):
+                        sane = False
             elif file[-2:] == "pc":
                 file_content = open(path).read()
                 if workdir in file_content:
-                    bb.error("QA issue: %s failed sanity test (reference to workdir)" % file )
+                    bb.error("QA issue: %s failed sanity test (workdir) in path %s" % \
+                            (file,root))
                     if package_qa_make_fatal_error( 6, "staging", path, d):
                         sane = False