[oe-commits] org.oe.dev classes/insane.bbclass: Allow errors to be ignored

[freyther commit]

classes/insane.bbclass: Allow errors to be ignored

    Add a method to implement koen's skipping of
    errors of type .so in non dev package. This
    will turn into a list of known and acked issues which
    we decided to ignore. I do not yet know how to maintain
    such a list properly though

    Split the .so in non-dev package and the .debug in non-dbg
    package into two different packages

Author: freyther at openembedded.org
Branch: org.openembedded.dev
Revision: 7ebd06970e2c9296f4bd61b23d65e46063c41150
ViewMTN: http://monotone.openembedded.org/revision.psp?id=7ebd06970e2c9296f4bd61b23d65e46063c41150
Files:
1
classes/insane.bbclass
Diffs:

#
# mt diff -r2eb3c6be268f092915ae3ff1da8f05e5e67b1c2a -r7ebd06970e2c9296f4bd61b23d65e46063c41150
#
# 
# 
# patch "classes/insane.bbclass"
#  from [f7d251426de3818874bf704becdc57844b015456]
#    to [6538fa2bc3ec58872af74fb0cf1b2696de4dbdf8]
# 
============================================================
--- classes/insane.bbclass	f7d251426de3818874bf704becdc57844b015456
+++ classes/insane.bbclass	6538fa2bc3ec58872af74fb0cf1b2696de4dbdf8
@@ -24,19 +24,41 @@ PACKAGEFUNCS += " do_package_qa "
 PACKAGE_DEPENDS += "pax-utils-native"
 PACKAGEFUNCS += " do_package_qa "
 
+#
+#
+# Known Error classes
+# 0 - non dev contains .so
+# 1 - package contains a dangerous RPATH
+# 2 - package depends on debug package
+# 3 - non dbg contains .so
+#
+#
+
 def package_qa_clean_path(path,d):
     import bb
     return path.replace(bb.data.getVar('TMPDIR',d,True),"")
 
+def package_qa_make_fatal_error(error_class, name, path,d):
+    """
+    decide if an error is fatal
+
+    TODO: Load a whitelist of known errors
+    """
+    if error_class == 0:
+        return False
+    else:
+        return True
+
 def package_qa_write_error(error_class, name, path, d):
     import bb, os
     if not bb.data.getVar('QA_LOG', d):
         return
 
     ERROR_NAMES =[
-        "dev/dbg contains .so",
+        "non dev contains .so",
         "package contains RPATH",
         "package depends on debug package",
+        "non dbg contains .debug",
     ]
 
 
@@ -80,13 +102,15 @@ def package_qa_check_devdbg(path, name,d
         if path[-3:] == ".so":
             package_qa_write_error( 0, name, path, d )
             bb.error("QA Issue: non dev package contains .so: %s path '%s'" % (name, package_qa_clean_path(path,d)))
-            sane = False
+            if package_qa_make_fatal_error( 0, name, path, d ):
+                sane = False
 
     if not "-dbg" in name:
         if '.debug' in path:
-            package_qa_write_error( 0, name, path, d )
+            package_qa_write_error( 3, name, path, d )
             bb.error("QA Issue: non debug package contains .debug directory: %s path %s" % (name, package_qa_clean_path(path,d)))
-            sane = False
+            if package_qa_make_fatal_error( 3, name, path, d ):
+                sane = False
 
     return sane
 
@@ -167,7 +191,8 @@ def package_qa_check_rdepends(pkg, workd
             if "-dbg" in rdepend:
                 package_qa_write_error( 2, name, rdepend, d )
                 bb.error("QA issue, koen give us a better msg!!!")
-                sane = False
+                if package_qa_make_fatal_error( 2, name, rdepend, d ):
+                    sane = False
 
     return sane