[oe-commits] org.oe.dev classes/insane.bbclass: No use to make it bb.fatal if we return False...

[freyther commit]

classes/insane.bbclass: No use to make it bb.fatal if we return False...

    The idea of insane.bbclass is to report all issues found at
    once. This is why the checks return True if no error was found
    and False if at least one was found.
    At the end of all check runs we will see if at least one check
    failed and call bb.fatal

Author: freyther at openembedded.org
Branch: org.openembedded.dev
Revision: 4386c713df23dab4cbfe2b846f556cb97ae69b9b
ViewMTN: http://monotone.openembedded.org/revision.psp?id=4386c713df23dab4cbfe2b846f556cb97ae69b9b
Files:
1
classes/insane.bbclass
Diffs:

#
# mt diff -r40506635aa9cd6082b6090104a6595f389f81e73 -r4386c713df23dab4cbfe2b846f556cb97ae69b9b
#
# 
# 
# patch "classes/insane.bbclass"
#  from [7b4c08d381d50887f082ef75ce8872d3382416e2]
#    to [65367d343a14d80b055e6c8aa3ab0b752cdaffee]
# 
============================================================
--- classes/insane.bbclass	7b4c08d381d50887f082ef75ce8872d3382416e2
+++ classes/insane.bbclass	65367d343a14d80b055e6c8aa3ab0b752cdaffee
@@ -257,14 +257,14 @@ def package_qa_check_arch(path,name,d):
 
     sane = True
     if not machine == elf.machine():
-        bb.fatal("Architecture did not match (%d to %d) on %s" %(machine, elf.machine(), package_qa_clean_path(path,d)))
+        bb.error("Architecture did not match (%d to %d) on %s" %(machine, elf.machine(), package_qa_clean_path(path,d)))
         sane = package_qa_make_fatal_error( 4, name, path, d )
-    elif not osabi == elf.osAbi():
-        bb.error("OSABI did not match (%d to %d) on %s" % (osabi, elf.osAbi(), package_qa_clean_path(path,d)))
-        sane = package_qa_make_fatal_error( 4, name, path, d )
-    elif not abiversion == elf.abiVersion():
-        bb.error("ABI version did not match (%d to %d) on %s" % (abiversion, elf.abiVersion(), package_qa_clean_path(path,d)))
-        sane = package_qa_make_fatal_error( 4, name, path, d )
+#    elif not osabi == elf.osAbi():
+#        bb.error("OSABI did not match (%d to %d) on %s" % (osabi, elf.osAbi(), package_qa_clean_path(path,d)))
+#        sane = package_qa_make_fatal_error( 4, name, path, d )
+#    elif not abiversion == elf.abiVersion():
+#        bb.error("ABI version did not match (%d to %d) on %s" % (abiversion, elf.abiVersion(), package_qa_clean_path(path,d)))
+#        sane = package_qa_make_fatal_error( 4, name, path, d )
     elif not littleendian == elf.isLittleEndian():
         bb.error("Endiannes did not match (%d to %d) on %s" % (littleendian, elf.isLittleEndian(), package_qa_clean_path(path,d)))
         sane = package_qa_make_fatal_error( 4, name, path, d )