[oe-commits] org.oe.dev linux-omap2 : Add patches to fix TWL4030 issues.
crofton commit
oe at amethyst.openembedded.net
Fri Jul 18 15:10:15 UTC 2008
linux-omap2 : Add patches to fix TWL4030 issues.
Author: crofton at openembedded.org
Branch: org.openembedded.dev
Revision: 83a3842e481b7407e271aa8542f64c8eea36f71f
ViewMTN: http://monotone.openembedded.org/revision/info/83a3842e481b7407e271aa8542f64c8eea36f71f
Files:
1
packages/linux/linux-omap2-git/beagleboard/TWL4030-01.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-02.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-03.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-04.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-05.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-06.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-07.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-08.patch
packages/linux/linux-omap2-git/beagleboard/TWL4030-09.patch
packages/linux/linux-omap2_git.bb
Diffs:
#
# mt diff -r42bad37322fc6e3a7c71fa99a3a80042ab020d2f -r83a3842e481b7407e271aa8542f64c8eea36f71f
#
#
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-01.patch"
# content [da576d5a0b54b0da52d31f95bc08b102a95ca3b2]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-02.patch"
# content [72af4f60c26f56679e95fc24ef3b7f5acabed0cf]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-03.patch"
# content [6284906123018747a79c7343545a7dd996b0ec39]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-04.patch"
# content [656d89877fe629bfe6899289054c523bb7eb2e91]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-05.patch"
# content [a89f99c1ea6b938b377f1ea97035e448fcbdb3b1]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-06.patch"
# content [01cb8404a54532d68de3d2db4af14c4da5e5a109]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-07.patch"
# content [a280d8f500e253c8816899f5b34ce803e200faee]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-08.patch"
# content [d2d7e987a7124b50a4c43b41bbbb6b26c7e49e0b]
#
# add_file "packages/linux/linux-omap2-git/beagleboard/TWL4030-09.patch"
# content [851122d7278bafa9d271aa4d3fdb81f61afeae01]
#
# patch "packages/linux/linux-omap2_git.bb"
# from [cea77c1d47097de58a869850834db878704774fc]
# to [824775d9f3efae0925325c500da99a9741527658]
#
============================================================
--- packages/linux/linux-omap2-git/beagleboard/TWL4030-01.patch da576d5a0b54b0da52d31f95bc08b102a95ca3b2
+++ packages/linux/linux-omap2-git/beagleboard/TWL4030-01.patch da576d5a0b54b0da52d31f95bc08b102a95ca3b2
@@ -0,0 +1,86 @@
+X-Mozilla-Status: 0001
+X-Mozilla-Status2: 00000000
+Return-Path: <linux-omap-owner at vger.kernel.org>
+X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on shovel.geekisp.com
+X-Spam-Level:
+X-Spam-Status: No, score=-1.1 required=5.0 tests=AWL,DKIM_POLICY_SIGNSOME
+ autolearn=ham version=3.2.1
+Delivered-To: balister.org-philip at balister.org
+Received: (qmail 26975 invoked by uid 1003); 18 Jul 2008 01:35:27 -0000
+Received: from vger.kernel.org (209.132.176.167)
+ by mail.geekisp.com with SMTP; 18 Jul 2008 01:35:27 -0000
+Received: (majordomo at vger.kernel.org) by vger.kernel.org via listexpand
+ id S1756265AbYGRBf0 (ORCPT <rfc822;philip at balister.org>);
+ Thu, 17 Jul 2008 21:35:26 -0400
+Received: (majordomo at vger.kernel.org) by vger.kernel.org id S1751582AbYGRBfZ
+ (ORCPT <rfc822;linux-omap-outgoing>);
+ Thu, 17 Jul 2008 21:35:25 -0400
+Received: from utopia.booyaka.com ([72.9.107.138]:49361 "EHLO
+ utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
+ with ESMTP id S1752321AbYGRBfX (ORCPT
+ <rfc822;linux-omap at vger.kernel.org>); Thu, 17 Jul 2008 21:35:23 -0400
+Received: (qmail 13868 invoked by uid 526); 18 Jul 2008 01:35:22 -0000
+MBOX-Line: From nobody Thu Jul 17 19:34:49 2008
+From: Paul Walmsley <paul at pwsan.com>
+Subject: [PATCH 1/9] TWL4030: remove superfluous PWR interrupt status clear
+ before masking
+To: linux-omap at vger.kernel.org
+Date: Thu, 17 Jul 2008 19:34:49 -0600
+Message-ID: <20080718013448.18943.6984.stgit at localhost.localdomain>
+In-Reply-To: <20080718013205.18943.34047.stgit at localhost.localdomain>
+References: <20080718013205.18943.34047.stgit at localhost.localdomain>
+User-Agent: StGIT/0.14.3.163.g06f9
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 7bit
+Sender: linux-omap-owner at vger.kernel.org
+Precedence: bulk
+List-ID: <linux-omap.vger.kernel.org>
+X-Mailing-List: linux-omap at vger.kernel.org
+
+twl_irq_init() clears PWR interrupt status bits, then masks the interrupts
+off, then clears the PWR interrupt status bits again. The first clear
+seems unnecessary, so, remove it.
+
+Signed-off-by: Paul Walmsley <paul at pwsan.com>
+---
+
+ drivers/i2c/chips/twl4030-core.c | 18 ------------------
+ 1 files changed, 0 insertions(+), 18 deletions(-)
+
+diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
+index adc45d4..ff662bc 100644
+--- a/drivers/i2c/chips/twl4030-core.c
++++ b/drivers/i2c/chips/twl4030-core.c
+@@ -719,24 +719,6 @@ static void twl_init_irq(void)
+ char *msg = "Unable to register interrupt subsystem";
+ unsigned int irq_num;
+
+- /*
+- * We end up with interrupts from other modules before
+- * they get a chance to handle them...
+- */
+- /* PWR_ISR1 */
+- res = twl4030_i2c_write_u8(TWL4030_MODULE_INT, 0xFF, 0x00);
+- if (res < 0) {
+- pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+- return;
+- }
+-
+- /* PWR_ISR2 */
+- res = twl4030_i2c_write_u8(TWL4030_MODULE_INT, 0xFF, 0x02);
+- if (res < 0) {
+- pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+- return;
+- }
+-
+ /* PWR_IMR1 */
+ res = twl4030_i2c_write_u8(TWL4030_MODULE_INT, 0xFF, 0x1);
+ if (res < 0) {
+
+
+--
+To unsubscribe from this list: send the line "unsubscribe linux-omap" in
+the body of a message to majordomo at vger.kernel.org
+More majordomo info at http://vger.kernel.org/majordomo-info.html
+
============================================================
--- packages/linux/linux-omap2-git/beagleboard/TWL4030-02.patch 72af4f60c26f56679e95fc24ef3b7f5acabed0cf
+++ packages/linux/linux-omap2-git/beagleboard/TWL4030-02.patch 72af4f60c26f56679e95fc24ef3b7f5acabed0cf
@@ -0,0 +1,114 @@
+X-Mozilla-Status: 0001
+X-Mozilla-Status2: 00000000
+Return-Path: <linux-omap-owner at vger.kernel.org>
+X-Spam-Checker-Version: SpamAssassin 3.2.2 (2007-07-23) on
+ morningsun.geekisp.com
+X-Spam-Level:
+X-Spam-Status: No, score=-3.0 required=5.0 tests=AWL,DKIM_POLICY_SIGNSOME,
+ DK_POLICY_SIGNSOME,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.2
+Delivered-To: balister.org-philip at balister.org
+Received: (qmail 17413 invoked by uid 1003); 18 Jul 2008 01:35:27 -0000
+Received: from vger.kernel.org (209.132.176.167)
+ by mail.geekisp.com with SMTP; 18 Jul 2008 01:35:27 -0000
+Received: (majordomo at vger.kernel.org) by vger.kernel.org via listexpand
+ id S1757296AbYGRBf1 (ORCPT <rfc822;philip at balister.org>);
+ Thu, 17 Jul 2008 21:35:27 -0400
+Received: (majordomo at vger.kernel.org) by vger.kernel.org id S1751582AbYGRBf0
+ (ORCPT <rfc822;linux-omap-outgoing>);
+ Thu, 17 Jul 2008 21:35:26 -0400
+Received: from utopia.booyaka.com ([72.9.107.138]:49362 "EHLO
+ utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
+ with ESMTP id S1754168AbYGRBfY (ORCPT
+ <rfc822;linux-omap at vger.kernel.org>); Thu, 17 Jul 2008 21:35:24 -0400
+Received: (qmail 13872 invoked by uid 526); 18 Jul 2008 01:35:23 -0000
+MBOX-Line: From nobody Thu Jul 17 19:34:50 2008
+From: Paul Walmsley <paul at pwsan.com>
+Subject: [PATCH 2/9] TWL4030: clear TWL GPIO interrupt status registers
+To: linux-omap at vger.kernel.org
+Date: Thu, 17 Jul 2008 19:34:50 -0600
+Message-ID: <20080718013449.18943.78895.stgit at localhost.localdomain>
+In-Reply-To: <20080718013205.18943.34047.stgit at localhost.localdomain>
+References: <20080718013205.18943.34047.stgit at localhost.localdomain>
+User-Agent: StGIT/0.14.3.163.g06f9
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 7bit
+Sender: linux-omap-owner at vger.kernel.org
+Precedence: bulk
+List-ID: <linux-omap.vger.kernel.org>
+X-Mailing-List: linux-omap at vger.kernel.org
+
+twl_init_irq() does not clear the TWL GPIO ISR registers, but the PIH
+ISR thinks that it has. This causes any previously-latched GPIO interrupts
+to be stuck on until twl4030-gpio.c initializes, often drowning the console in
+
+ TWL4030 module irq 368 is disabled but can't be masked!
+
+messages. This seems to be a particular problem when booting on Beagle.
+
+Signed-off-by: Paul Walmsley <paul at pwsan.com>
+---
+
+ drivers/i2c/chips/twl4030-core.c | 42 ++++++++++++++++++++++++++++++++++++++
+ 1 files changed, 42 insertions(+), 0 deletions(-)
+
+diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
+index ff662bc..dfc3805 100644
+--- a/drivers/i2c/chips/twl4030-core.c
++++ b/drivers/i2c/chips/twl4030-core.c
+@@ -857,6 +857,48 @@ static void twl_init_irq(void)
+ return;
+ }
+
++ /* GPIO_ISR1A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x19);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* GPIO_ISR2A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1a);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* GPIO_ISR3A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1b);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* GPIO_ISR1B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x1f);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* GPIO_ISR2B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x20);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* GPIO_ISR3B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, 0xff, 0x21);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
+ /* install an irq handler for each of the PIH modules */
+ for (i = TWL4030_IRQ_BASE; i < TWL4030_IRQ_END; i++) {
+ set_irq_chip(i, &twl4030_irq_chip);
+
+
+--
+To unsubscribe from this list: send the line "unsubscribe linux-omap" in
+the body of a message to majordomo at vger.kernel.org
+More majordomo info at http://vger.kernel.org/majordomo-info.html
+
============================================================
--- packages/linux/linux-omap2-git/beagleboard/TWL4030-03.patch 6284906123018747a79c7343545a7dd996b0ec39
+++ packages/linux/linux-omap2-git/beagleboard/TWL4030-03.patch 6284906123018747a79c7343545a7dd996b0ec39
@@ -0,0 +1,126 @@
+X-Mozilla-Status: 0001
+X-Mozilla-Status2: 00000000
+Return-Path: <linux-omap-owner at vger.kernel.org>
+X-Spam-Checker-Version: SpamAssassin 3.2.2 (2007-07-23) on
+ morningsun.geekisp.com
+X-Spam-Level:
+X-Spam-Status: No, score=-3.0 required=5.0 tests=AWL,DKIM_POLICY_SIGNSOME,
+ DK_POLICY_SIGNSOME,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.2
+Delivered-To: balister.org-philip at balister.org
+Received: (qmail 14206 invoked by uid 1003); 18 Jul 2008 01:35:28 -0000
+Received: from vger.kernel.org (209.132.176.167)
+ by mail.geekisp.com with SMTP; 18 Jul 2008 01:35:28 -0000
+Received: (majordomo at vger.kernel.org) by vger.kernel.org via listexpand
+ id S1751582AbYGRBf1 (ORCPT <rfc822;philip at balister.org>);
+ Thu, 17 Jul 2008 21:35:27 -0400
+Received: (majordomo at vger.kernel.org) by vger.kernel.org id S1754168AbYGRBf1
+ (ORCPT <rfc822;linux-omap-outgoing>);
+ Thu, 17 Jul 2008 21:35:27 -0400
+Received: from utopia.booyaka.com ([72.9.107.138]:49363 "EHLO
+ utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
+ with ESMTP id S1754586AbYGRBfY (ORCPT
+ <rfc822;linux-omap at vger.kernel.org>); Thu, 17 Jul 2008 21:35:24 -0400
+Received: (qmail 13876 invoked by uid 526); 18 Jul 2008 01:35:23 -0000
+MBOX-Line: From nobody Thu Jul 17 19:34:50 2008
+From: Paul Walmsley <paul at pwsan.com>
+Subject: [PATCH 3/9] TWL4030: use correct register addresses for BCI IMR
+ registers
+To: linux-omap at vger.kernel.org
+Date: Thu, 17 Jul 2008 19:34:50 -0600
+Message-ID: <20080718013450.18943.33123.stgit at localhost.localdomain>
+In-Reply-To: <20080718013205.18943.34047.stgit at localhost.localdomain>
+References: <20080718013205.18943.34047.stgit at localhost.localdomain>
+User-Agent: StGIT/0.14.3.163.g06f9
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 7bit
+Sender: linux-omap-owner at vger.kernel.org
+Precedence: bulk
+List-ID: <linux-omap.vger.kernel.org>
+X-Mailing-List: linux-omap at vger.kernel.org
+
+The existing code to mask and clear BCI interrupts in twl_init_irq() is
+wrong. It uses the wrong register offsets, it does not mask all of the
+BCI IMR registers, and it does not clear all of the BCI ISR registers.
+
+Signed-off-by: Paul Walmsley <paul at pwsan.com>
+---
+
+ drivers/i2c/chips/twl4030-core.c | 40 ++++++++++++++++++++++++++++++++------
+ 1 files changed, 34 insertions(+), 6 deletions(-)
+
+diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
+index dfc3805..bb0732c 100644
+--- a/drivers/i2c/chips/twl4030-core.c
++++ b/drivers/i2c/chips/twl4030-core.c
+@@ -750,29 +750,57 @@ static void twl_init_irq(void)
+ /* POWER HACK (END) */
+ /* Slave address 0x4A */
+
+- /* BCIIMR1_1 */
++ /* BCIIMR1A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x2);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* BCIIMR2A */
+ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x3);
+ if (res < 0) {
+ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+ return;
+ }
+
+- /* BCIIMR1_2 */
+- res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x4);
++ /* BCIIMR1B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x6);
+ if (res < 0) {
+ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+ return;
+ }
+
+- /* BCIIMR2_1 */
++ /* BCIIMR2B */
+ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x7);
+ if (res < 0) {
+ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+ return;
+ }
+
+- /* BCIIMR2_2 */
+- res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x8);
++ /* BCIISR1A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x0);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* BCIISR2A */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x1);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* BCIISR1B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x4);
++ if (res < 0) {
++ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
++ return;
++ }
++
++ /* BCIISR2B */
++ res = twl4030_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xFF, 0x5);
+ if (res < 0) {
+ pr_err("%s[%d][%d]\n", msg, res, __LINE__);
+ return;
+
+
+--
+To unsubscribe from this list: send the line "unsubscribe linux-omap" in
+the body of a message to majordomo at vger.kernel.org
+More majordomo info at http://vger.kernel.org/majordomo-info.html
+
============================================================
--- packages/linux/linux-omap2-git/beagleboard/TWL4030-04.patch 656d89877fe629bfe6899289054c523bb7eb2e91
+++ packages/linux/linux-omap2-git/beagleboard/TWL4030-04.patch 656d89877fe629bfe6899289054c523bb7eb2e91
@@ -0,0 +1,81 @@
+X-Mozilla-Status: 0001
+X-Mozilla-Status2: 00000000
+Return-Path: <linux-omap-owner at vger.kernel.org>
+X-Spam-Checker-Version: SpamAssassin 3.2.2 (2007-07-23) on
+ morningsun.geekisp.com
+X-Spam-Level:
+X-Spam-Status: No, score=-3.0 required=5.0 tests=AWL,DKIM_POLICY_SIGNSOME,
+ DK_POLICY_SIGNSOME,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.2
+Delivered-To: balister.org-philip at balister.org
+Received: (qmail 21713 invoked by uid 1003); 18 Jul 2008 01:35:29 -0000
+Received: from vger.kernel.org (209.132.176.167)
+ by mail.geekisp.com with SMTP; 18 Jul 2008 01:35:29 -0000
+Received: (majordomo at vger.kernel.org) by vger.kernel.org via listexpand
+ id S1754758AbYGRBf2 (ORCPT <rfc822;philip at balister.org>);
+ Thu, 17 Jul 2008 21:35:28 -0400
+Received: (majordomo at vger.kernel.org) by vger.kernel.org id S1757008AbYGRBf1
+ (ORCPT <rfc822;linux-omap-outgoing>);
+ Thu, 17 Jul 2008 21:35:27 -0400
+Received: from utopia.booyaka.com ([72.9.107.138]:49364 "EHLO
+ utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
+ with ESMTP id S1754758AbYGRBfY (ORCPT
+ <rfc822;linux-omap at vger.kernel.org>); Thu, 17 Jul 2008 21:35:24 -0400
+Received: (qmail 13880 invoked by uid 526); 18 Jul 2008 01:35:23 -0000
+MBOX-Line: From nobody Thu Jul 17 19:34:51 2008
+From: Paul Walmsley <paul at pwsan.com>
+Subject: [PATCH 4/9] TWL4030: clear MADC interrupt status registers upon init
+To: linux-omap at vger.kernel.org
+Date: Thu, 17 Jul 2008 19:34:51 -0600
+Message-ID: <20080718013450.18943.33397.stgit at localhost.localdomain>
+In-Reply-To: <20080718013205.18943.34047.stgit at localhost.localdomain>
+References: <20080718013205.18943.34047.stgit at localhost.localdomain>
+User-Agent: StGIT/0.14.3.163.g06f9
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 7bit
+Sender: linux-omap-owner at vger.kernel.org
+Precedence: bulk
+List-ID: <linux-omap.vger.kernel.org>
+X-Mailing-List: linux-omap at vger.kernel.org
+
+twl_init_irq() does not clear MADC interrupt status r%s
>>> DIFF TRUNCATED @ 16K
More information about the Openembedded-commits
mailing list