[oe-commits] org.oe.dev linux-omap2 git: bump to 2.6.26rc2, add patch to fix boot on beagleboard
koen commit
oe at amethyst.openembedded.net
Thu May 15 07:20:22 UTC 2008
linux-omap2 git: bump to 2.6.26rc2, add patch to fix boot on beagleboard
Author: koen at openembedded.org
Branch: org.openembedded.dev
Revision: 73a23186ee8c84f6b4f8391bda1d41f034358c5c
ViewMTN: http://monotone.openembedded.org/revision/info/73a23186ee8c84f6b4f8391bda1d41f034358c5c
Files:
1
packages/linux/linux-omap2-git/beagleboard/convert-rwsem-to-rwclock.patch
packages/linux/linux-omap2_git.bb
Diffs:
#
# mt diff -r08f0974ebf10be6a9cf488e0ff5a9505bb7bac0e -r73a23186ee8c84f6b4f8391bda1d41f034358c5c
#
#
#
# add_file "packages/linux/linux-omap2-git/beagleboard/convert-rwsem-to-rwclock.patch"
# content [453d581791afa5d02d68c029a3a169b37d15152b]
#
# patch "packages/linux/linux-omap2_git.bb"
# from [3b6da60c8cd98f8fc757ec97487827f45027fb50]
# to [573a35cf42a27118c23921862fcdcd0aec378794]
#
============================================================
--- packages/linux/linux-omap2-git/beagleboard/convert-rwsem-to-rwclock.patch 453d581791afa5d02d68c029a3a169b37d15152b
+++ packages/linux/linux-omap2-git/beagleboard/convert-rwsem-to-rwclock.patch 453d581791afa5d02d68c029a3a169b37d15152b
@@ -0,0 +1,220 @@
+The generic rwsem implementation of down_read() and down_write() does not
+save and restore interrupt state. This causes powerdomain code to
+inadvertently enable interrupts early in the boot process, causing
+init/main.c to complain. This patch converts powerdomain locking to
+r-w spinlocks instead.
+
+I'm also curious to know if this fixes the BeagleBoard boot problem.
+
+Signed-off-by: Paul Walmsley <paul at pwsan.com>
+---
+
+ arch/arm/mach-omap2/powerdomain.c | 46 ++++++++++++++++++++++---------------
+ 1 files changed, 27 insertions(+), 19 deletions(-)
+
+
+diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
+index 939efe4..0a6caaf 100644
+--- a/arch/arm/mach-omap2/powerdomain.c
++++ b/arch/arm/mach-omap2/powerdomain.c
+@@ -18,7 +18,7 @@
+ #include <linux/module.h>
+ #include <linux/types.h>
+ #include <linux/delay.h>
+-#include <linux/rwsem.h>
++#include <linux/spinlock.h>
+ #include <linux/list.h>
+ #include <linux/errno.h>
+ #include <linux/err.h>
+@@ -38,10 +38,10 @@
+ static LIST_HEAD(pwrdm_list);
+
+ /*
+- * pwrdm_rwsem protects pwrdm_list add and del ops - also reused to
++ * pwrdm_rwlock protects pwrdm_list add and del ops - also reused to
+ * protect pwrdm_clkdms[] during clkdm add/del ops
+ */
+-static DECLARE_RWSEM(pwrdm_rwsem);
++static DEFINE_RWLOCK(pwrdm_rwlock);
+
+
+ /* Private functions */
+@@ -131,6 +131,7 @@ void pwrdm_init(struct powerdomain **pwrdm_list)
+ */
+ int pwrdm_register(struct powerdomain *pwrdm)
+ {
++ unsigned long flags;
+ int ret = -EINVAL;
+
+ if (!pwrdm)
+@@ -139,7 +140,7 @@ int pwrdm_register(struct powerdomain *pwrdm)
+ if (!omap_chip_is(pwrdm->omap_chip))
+ return -EINVAL;
+
+- down_write(&pwrdm_rwsem);
++ write_lock_irqsave(&pwrdm_rwlock, flags);
+ if (_pwrdm_lookup(pwrdm->name)) {
+ ret = -EEXIST;
+ goto pr_unlock;
+@@ -151,7 +152,7 @@ int pwrdm_register(struct powerdomain *pwrdm)
+ ret = 0;
+
+ pr_unlock:
+- up_write(&pwrdm_rwsem);
++ write_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return ret;
+ }
+@@ -165,12 +166,14 @@ pr_unlock:
+ */
+ int pwrdm_unregister(struct powerdomain *pwrdm)
+ {
++ unsigned long flags;
++
+ if (!pwrdm)
+ return -EINVAL;
+
+- down_write(&pwrdm_rwsem);
++ write_lock_irqsave(&pwrdm_rwlock, flags);
+ list_del(&pwrdm->node);
+- up_write(&pwrdm_rwsem);
++ write_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ pr_debug("powerdomain: unregistered %s\n", pwrdm->name);
+
+@@ -187,13 +190,14 @@ int pwrdm_unregister(struct powerdomain *pwrdm)
+ struct powerdomain *pwrdm_lookup(const char *name)
+ {
+ struct powerdomain *pwrdm;
++ unsigned long flags;
+
+ if (!name)
+ return NULL;
+
+- down_read(&pwrdm_rwsem);
++ read_lock_irqsave(&pwrdm_rwlock, flags);
+ pwrdm = _pwrdm_lookup(name);
+- up_read(&pwrdm_rwsem);
++ read_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return pwrdm;
+ }
+@@ -204,7 +208,7 @@ struct powerdomain *pwrdm_lookup(const char *name)
+ *
+ * Call the supplied function for each registered powerdomain. The
+ * callback function can return anything but 0 to bail out early from
+- * the iterator. The callback function is called with the pwrdm_rwsem
++ * the iterator. The callback function is called with the pwrdm_rwlock
+ * held for reading, so no powerdomain structure manipulation
+ * functions should be called from the callback, although hardware
+ * powerdomain control functions are fine. Returns the last return
+@@ -215,18 +219,19 @@ struct powerdomain *pwrdm_lookup(const char *name)
+ int pwrdm_for_each(int (*fn)(struct powerdomain *pwrdm))
+ {
+ struct powerdomain *temp_pwrdm;
++ unsigned long flags;
+ int ret = 0;
+
+ if (!fn)
+ return -EINVAL;
+
+- down_read(&pwrdm_rwsem);
++ read_lock_irqsave(&pwrdm_rwlock, flags);
+ list_for_each_entry(temp_pwrdm, &pwrdm_list, node) {
+ ret = (*fn)(temp_pwrdm);
+ if (ret)
+ break;
+ }
+- up_read(&pwrdm_rwsem);
++ read_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return ret;
+ }
+@@ -243,6 +248,7 @@ int pwrdm_for_each(int (*fn)(struct powerdomain *pwrdm))
+ */
+ int pwrdm_add_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ {
++ unsigned long flags;
+ int i;
+ int ret = -EINVAL;
+
+@@ -252,7 +258,7 @@ int pwrdm_add_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ pr_debug("powerdomain: associating clockdomain %s with powerdomain "
+ "%s\n", clkdm->name, pwrdm->name);
+
+- down_write(&pwrdm_rwsem);
++ write_lock_irqsave(&pwrdm_rwlock, flags);
+
+ for (i = 0; i < PWRDM_MAX_CLKDMS; i++) {
+ if (!pwrdm->pwrdm_clkdms[i])
+@@ -278,7 +284,7 @@ int pwrdm_add_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ ret = 0;
+
+ pac_exit:
+- up_write(&pwrdm_rwsem);
++ write_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return ret;
+ }
+@@ -295,6 +301,7 @@ pac_exit:
+ */
+ int pwrdm_del_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ {
++ unsigned long flags;
+ int ret = -EINVAL;
+ int i;
+
+@@ -304,7 +311,7 @@ int pwrdm_del_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ pr_debug("powerdomain: dissociating clockdomain %s from powerdomain "
+ "%s\n", clkdm->name, pwrdm->name);
+
+- down_write(&pwrdm_rwsem);
++ write_lock_irqsave(&pwrdm_rwlock, flags);
+
+ for (i = 0; i < PWRDM_MAX_CLKDMS; i++)
+ if (pwrdm->pwrdm_clkdms[i] == clkdm)
+@@ -322,7 +329,7 @@ int pwrdm_del_clkdm(struct powerdomain *pwrdm, struct clockdomain *clkdm)
+ ret = 0;
+
+ pdc_exit:
+- up_write(&pwrdm_rwsem);
++ write_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return ret;
+ }
+@@ -335,7 +342,7 @@ pdc_exit:
+ * Call the supplied function for each clockdomain in the powerdomain
+ * 'pwrdm'. The callback function can return anything but 0 to bail
+ * out early from the iterator. The callback function is called with
+- * the pwrdm_rwsem held for reading, so no powerdomain structure
++ * the pwrdm_rwlock held for reading, so no powerdomain structure
+ * manipulation functions should be called from the callback, although
+ * hardware powerdomain control functions are fine. Returns -EINVAL
+ * if presented with invalid pointers; or passes along the last return
+@@ -346,18 +353,19 @@ int pwrdm_for_each_clkdm(struct powerdomain *pwrdm,
+ int (*fn)(struct powerdomain *pwrdm,
+ struct clockdomain *clkdm))
+ {
++ unsigned long flags;
+ int ret = 0;
+ int i;
+
+ if (!fn)
+ return -EINVAL;
+
+- down_read(&pwrdm_rwsem);
++ read_lock_irqsave(&pwrdm_rwlock, flags);
+
+ for (i = 0; i < PWRDM_MAX_CLKDMS && !ret; i++)
+ ret = (*fn)(pwrdm, pwrdm->pwrdm_clkdms[i]);
+
+- up_read(&pwrdm_rwsem);
++ read_unlock_irqrestore(&pwrdm_rwlock, flags);
+
+ return ret;
+ }
+--
+To unsubscribe from this list: send the line "unsubscribe linux-omap" in
+the body of a message to majordomo at vger.kernel.org
+More majordomo info at http://vger.kernel.org/majordomo-info.html
+
============================================================
--- packages/linux/linux-omap2_git.bb 3b6da60c8cd98f8fc757ec97487827f45027fb50
+++ packages/linux/linux-omap2_git.bb 573a35cf42a27118c23921862fcdcd0aec378794
@@ -2,9 +2,10 @@ FILESDIR = "${@os.path.dirname(bb.data.g
FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/linux-omap2-git/${MACHINE}"
-SRCREV = "cb170dcdce58de20b045ae964a4ccfc29aad1647"
+SRCREV = "a59e04f09caf72992577775c89849a821f839858"
+#cb170dcdce58de20b045ae964a4ccfc29aad1647"
-PV = "2.6.25+2.6.26-rc1+git${SRCREV}"
+PV = "2.6.25+2.6.26-rc2+git${SRCREV}"
PR = "r12"
@@ -17,6 +18,7 @@ SRC_URI_append_beagleboard = " file://no
file://0001-This-patch-adds-RTC-support-to-the-omap3-based-beagl.patch;patch=1 \
file://0001-omap3beagle-add-driver-to-turn-on-the-TFP410-framer.patch;patch=1 \
file://l2-cache-check.patch;patch=1 \
+ file://convert-rwsem-to-rwclock.patch;patch=1 \
"
COMPATIBLE_MACHINE = "omap2430sdp|omap2420h4|beagleboard"
More information about the Openembedded-commits
mailing list