[oe-commits] Koen Kooi : x264: fix a few bugs

[GIT User account]

Module: openembedded.git
Branch: org.openembedded.dev
Commit: 308bbb0a550a70439701834dae44447f24383fa7
URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=308bbb0a550a70439701834dae44447f24383fa7

Author: Koen Kooi <koen at openembedded.org>
Date:   Sat Mar 28 18:40:37 2009 +0100

x264: fix a few bugs
* quoting EXTRA_OECONF = "something"$FOO"" is wrong
* passing --enable-shared and then doing CFLAGS += -static is wrong as well
* the beagleboard 'optimizations' were duplicating flags already there, and worse passed in O3 when O4 was the default
* adding machine optimizations without changing package arch is wrong as well

---

 recipes/vlc/x264_r2245.bb |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
index f7d43ea..e16e96b 100644
--- a/recipes/vlc/x264_r2245.bb
+++ b/recipes/vlc/x264_r2245.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "H.264 encoder"
 LICENSE = "GPL"
-PR = "r1"
+PR = "r2"
 
 X264PV = "snapshot-20090127-2245"
 
@@ -13,19 +13,12 @@ inherit autotools lib_package
 # default --extra-cflags
 X264_ECFLAGS = ""
 
-# optimizing --extra-cflags for beagleboard
-X264_ECFLAGS_beagleboard = " \
-        -s -save-temps -static -Wall -O3 -march=armv7-a \
-        -mtune=cortex-a8 -mcpu=cortex-a8 -mfloat-abi=softfp \
-        -mfpu=neon -ftree-vectorize -fomit-frame-pointer -ffast-math \
-"
-
 # disable use of assembler written functions
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 #X264_DISABLE_ASM_x86 = ""
 
-EXTRA_OECONF = "--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}""
+EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'
 
 do_stage() {
         autotools_stage_all