[oe-commits] Denis 'Gnutoo' Carikli : pngcrush_1.6.4.bb : use BPN( fixes pngcrush-native install)

git version control git at git.openembedded.org
Thu Jan 28 09:00:36 UTC 2010


Module: openembedded.git
Branch: shr/unstable
Commit: 269e3d5199f7db81effd65b6e53468864b414aa3
URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=269e3d5199f7db81effd65b6e53468864b414aa3

Author: Denis 'Gnutoo' Carikli <GNUtoo at no-log.org>
Date:   Mon Jan 25 16:03:02 2010 +0100

pngcrush_1.6.4.bb : use BPN(fixes pngcrush-native install)

The problem is that pngcrush-native fails during the installation
  because of this code in pngcrush_1.6.4.bb:
   install -m 755 ${PN} ${D}${bindir}
  that is in the do_install function.
  This code is inherited by pngcrush-native because
  pngcrush-native requires pngcrush_${PV}.bb,and PN becomes pngcrush-native
  instead of pngcrush and so it fails.

  Thanks hrw for learning me how to fix it easily(without copying
   the do_install function from pngcrush_1.6.4.bb into pngcrush-native)

  The effect of BPN on the 2 recipes was tested in bitbake -i

  Not changing PR because it doesn't change anything on
   pngcrush_1.6.4.bb's side,and on pngcrush-native's side it was
   just a compilation failure

---

 recipes/pngcrush/pngcrush_1.6.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/pngcrush/pngcrush_1.6.4.bb b/recipes/pngcrush/pngcrush_1.6.4.bb
index 9f0413a..8d37811 100644
--- a/recipes/pngcrush/pngcrush_1.6.4.bb
+++ b/recipes/pngcrush/pngcrush_1.6.4.bb
@@ -10,5 +10,5 @@ EXTRA_OEMAKE = "CC='${CC}' CFLAGS='${CFLAGS}' LD='${CC}'"
 
 do_install () {
         install -d ${D}${bindir}
-        install -m 755 ${PN} ${D}${bindir}
+        install -m 755 ${BPN} ${D}${bindir}
 }





More information about the Openembedded-commits mailing list