[oe-commits] Chris Larson : sanity.bbclass: Run our checking at BuildStarted, not ConfigParsed

git version control git at git.openembedded.org
Mon Jul 26 16:02:22 UTC 2010


Module: openembedded.git
Branch: org.openembedded.dev
Commit: bbc3d4827417d047094b4faafdda9dd2f50422ff
URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=bbc3d4827417d047094b4faafdda9dd2f50422ff

Author: Chris Larson <chris_larson at mentor.com>
Date:   Mon Jul 26 08:57:57 2010 -0700

sanity.bbclass: Run our checking at BuildStarted, not ConfigParsed

ConfigParsed is often utilized to do programmatic changes to the configuration
metadata.  If these other event handlers set any variables which
sanity.bbclass needs to check, there's a problem, since we can't ensure those
handlers run before this one.  So, we move the sanity checking to when the
build is about to start, this ensures that the configuration metadata is
entirely ready to go.

Signed-off-by: Chris Larson <chris_larson at mentor.com>

---

 classes/sanity.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass
index cff415a..1fd5fbb 100644
--- a/classes/sanity.bbclass
+++ b/classes/sanity.bbclass
@@ -188,8 +188,8 @@ def check_sanity(e):
 	if messages != "":
 		raise_sanity_error(messages)
 
-addhandler check_sanity_eventhandler
 python check_sanity_eventhandler() {
-    if bb.event.getName(e) == "ConfigParsed":
+    if isinstance(e, bb.event.BuildStarted):
         check_sanity(e)
 }
+addhandler check_sanity_eventhandler





More information about the Openembedded-commits mailing list