[oe-commits] Chris Larson : utils: drop exported var env caching for oe_popen

[git version control]

Module: openembedded.git
Branch: shr/testing2011.1
Commit: b0d90442542daa416f67ac003b00fadced2b4338
URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=b0d90442542daa416f67ac003b00fadced2b4338

Author: Chris Larson <chris_larson at mentor.com>
Date:   Mon Feb 14 12:41:50 2011 -0500

utils: drop exported var env caching for oe_popen

This was dangerous, as an oe_run executed from the configuration metadata
would result in caching the config metadata information, rather than the final
metadata information.  We could also cache it by the datasmart instance, but I
don't think its worth the trouble at this time, particularly given the next
bitbake release exports all exported vars into the process environment
automatically, avoiding the need for any of this.

Signed-off-by: Chris Larson <chris_larson at mentor.com>

---

 classes/utils.bbclass |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/classes/utils.bbclass b/classes/utils.bbclass
index 4cc6896..6f1906f 100644
--- a/classes/utils.bbclass
+++ b/classes/utils.bbclass
@@ -62,13 +62,10 @@ def is_machine_specific(d):
             return True
 
 def oe_popen_env(d):
-    env = d.getVar("__oe_popen_env", False)
-    if env is None:
-        env = {}
-        for v in d.keys():
-            if d.getVarFlag(v, "export"):
-                env[v] = d.getVar(v, True) or ""
-        d.setVar("__oe_popen_env", env)
+    env = {}
+    for v in d.keys():
+        if d.getVarFlag(v, "export"):
+            env[v] = d.getVar(v, True) or ""
     return env
 
 def oe_run(d, cmd, **kwargs):