[oe-commits] Tom Rini : insane.bbclass: Make RPATH a non-fatal error
git version control
git at git.openembedded.org
Fri Feb 18 21:44:16 UTC 2011
Module: openembedded.git
Branch: trini/simplify-target-flags
Commit: 37550c46658ef1e8ced24a47ad6e0bbdca5949bf
URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=37550c46658ef1e8ced24a47ad6e0bbdca5949bf
Author: Tom Rini <tom_rini at mentor.com>
Date: Sat Feb 19 03:26:27 2011 +0000
insane.bbclass: Make RPATH a non-fatal error
In order to make the user experience better we now use bb.warn
on non-fatal QA errors and bb.error on fatal errors.
Signed-off-by: Tom Rini <tom_rini at mentor.com>
Acked-by: Khem Raj <raj.khem at gmail.com>
Acked-by: Denys Dmytriyenko <denys at ti.com>
---
classes/insane.bbclass | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index a846832..3b042c9 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -116,7 +116,7 @@ def package_qa_make_fatal_error(error_class, name, path,d):
TODO: Load a whitelist of known errors
"""
- return not error_class in [0, 5, 7]
+ return not error_class in [0, 1, 5, 7]
def package_qa_write_error(error_class, name, path, d):
"""
@@ -145,10 +145,16 @@ def package_qa_write_error(error_class, name, path, d):
(ERROR_NAMES[error_class], name, package_qa_clean_path(path,d))
f.close()
+# Returns False is there was a fatal problem and True if we did not hit a fatal
+# error
def package_qa_handle_error(error_class, error_msg, name, path, d):
- bb.error("QA Issue with %s: %s" % (name, error_msg))
+ fatal = package_qa_make_fatal_error(error_class, name, path, d)
package_qa_write_error(error_class, name, path, d)
- return not package_qa_make_fatal_error(error_class, name, path, d)
+ if fatal:
+ bb.error("QA Issue with %s: %s" % (name, error_msg))
+ else:
+ bb.warn("QA Issue with %s: %s" % (name, error_msg))
+ return not fatal
def package_qa_check_rpath(file,name,d, elf):
"""
More information about the Openembedded-commits
mailing list