[oe-commits] Bob Foerster : x264_r2245: do not override `DEPENDS` for x86

[git version control]

Module: openembedded.git
Branch: master
Commit: 0409d1d98a400c56d348de1f49c8a09f38b52fba
URL:    http://git.openembedded.org/?p=openembedded.git&a=commit;h=0409d1d98a400c56d348de1f49c8a09f38b52fba

Author: Bob Foerster <robert at erafx.com>
Date:   Sun May  8 07:00:53 2011 -0400

x264_r2245: do not override `DEPENDS` for x86

The recipe intended to add "yasm-native" to the dependencies on x86,
but it set DEPENDS_x86 = "yasm-native" which obliterated the base
dependencies [1]. On a fresh build, this package was failing since it there
was no compiler.

	+ /oe/build-angstrom-next/angstrom-dev/work/i486-angstrom-linux/x264-r2245-r8/x264-snapshot-20100531-2245/configure --build=i686-linux --host=i486-angstrom-linux --target
	=i486-angstrom-linux --prefix=/usr --exec_prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --libexecdir=/usr/libexec --datadir=/usr/share -
	-sysconfdir=/etc --sharedstatedir=/com --localstatedir=/var --libdir=/usr/lib --includedir=/usr/include --oldincludedir=/usr/include --infodir=/usr/share/info --mandir=/usr/share/man --with-libtool-sysroot=/oe/build-angstrom-next/angstrom-dev/sysroots/i486-angstrom-linux --enable-largefile --disable-nls --enable-ipv6 --enable-shared --extra-cflags=
	Unknown option --build=i686-linux, ignored
	Unknown option --target=i486-angstrom-linux, ignored
	Unknown option --exec_prefix=/usr, ignored
	Unknown option --sbindir=/usr/sbin, ignored
	Unknown option --libexecdir=/usr/libexec, ignored
	Unknown option --datadir=/usr/share, ignored
	Unknown option --sysconfdir=/etc, ignored
	Unknown option --sharedstatedir=/com, ignored
	Unknown option --localstatedir=/var, ignored
	Unknown option --oldincludedir=/usr/include, ignored
	Unknown option --infodir=/usr/share/info, ignored
	Unknown option --mandir=/usr/share/man, ignored
	Unknown option --with-libtool-sysroot=/oe/build-angstrom-next/angstrom-dev/sysroots/i486-angstrom-linux, ignored
	Unknown option --enable-largefile, ignored
	Unknown option --disable-nls, ignored
	Unknown option --enable-ipv6, ignored
	No working C compiler found.

Depends is now set with DEPENDS_append_x86, which leaves the base
dependencies intact.

This patch is tested using a custom distribution for `MACHINE = "x86"`.

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032478.html

Signed-off-by: Bob Foerster <robert at erafx.com>
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>

---

 recipes/vlc/x264_r2245.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
index 0cffea3..21e5a0e 100644
--- a/recipes/vlc/x264_r2245.bb
+++ b/recipes/vlc/x264_r2245.bb
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
 X264_DISABLE_ASM = "--disable-asm"
 # use assembler written functions for those archs supporting this
 X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
 
 EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'