[oe-commits] Otavio Salvador : send-pull-request: drop sendemail checks

git version control git at git.openembedded.org
Wed May 25 14:50:17 UTC 2011


Module: openembedded-core.git
Branch: master
Commit: b75cf390d75957f5b5718892942f76fc4295270f
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=b75cf390d75957f5b5718892942f76fc4295270f

Author: Otavio Salvador <otavio at ossystems.com.br>
Date:   Fri May 20 20:36:33 2011 +0000

send-pull-request: drop sendemail checks

git send-email has the correct check on it. Basically the From is
taken from the git 'user' and 'email' config values and in case
'sendemail.smtpserver' is not provided it defaults to use local
sendmail command.

Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
Acked-by: Darren Hart <dvhart at linux.intel.com>

---

 scripts/send-pull-request |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index cee9253..5dfc246 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -67,19 +67,6 @@ harvest_recipients()
 	unset IFS
 }
 
-check_git_sendemail_config()
-{
-	GIT_SMTP=$(git config sendemail.smtpserver)
-	GIT_FROM=$(git config sendemail.from)
-	if [ -z "$GIT_SMTP" ] || [ -z "$GIT_FROM" ]; then
-		echo "ERROR: git sendemail is not configured."
-		echo "Please read GIT-SEND-EMAIL(1) and configure:"
-		echo "  sendemail.smtpserver"
-		echo "  sendemail.from"
-		exit 1
-	fi
-}
-
 # Parse and verify arguments
 while getopts "achp:t:" OPT; do
 	case $OPT in
@@ -113,9 +100,6 @@ while getopts "achp:t:" OPT; do
 	esac
 done
 
-# Abort early if git-send-email is not properly configured
-check_git_sendemail_config
-
 if [ -z "$PDIR" ]; then
 	echo "ERROR: you must specify a pull-dir."
 	usage





More information about the Openembedded-commits mailing list