[oe-commits] Richard Purdie : sanity.bbclass: If the sanity tests fail, don' t mark them as complete

git at git.openembedded.org git at git.openembedded.org
Tue Apr 17 11:32:01 UTC 2012


Module: openembedded-core.git
Branch: master
Commit: b99acaa8aa06dcbca46c3f7048124d6f8d643a8b
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=b99acaa8aa06dcbca46c3f7048124d6f8d643a8b

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Tue Apr 17 11:16:18 2012 +0000

sanity.bbclass: If the sanity tests fail, don't mark them as complete

If the sanity tests fail, we still were writing out the stamp which means
they'd get skipped the next time we run bitbake. This is clearly wrong
and we should only write out the stamp file if the sanity tests complete
successfully.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 1b941ac..4d4abd3 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -378,7 +378,7 @@ def check_sanity(e):
         if last_sstate_dir != sstate_dir:
             messages = messages + check_sanity_sstate_dir_change(sstate_dir, e.data)
 
-    if os.path.exists("conf"):
+    if os.path.exists("conf") and not messages:
         f = file(sanityverfile, 'w')
         f.write("SANITY_VERSION %s\n" % sanity_version) 
         f.write("TMPDIR %s\n" % tmpdir) 





More information about the Openembedded-commits mailing list