[oe-commits] Richard Purdie : utils.bbclass: Testing via env in create_wrapper is a nice idea but breaks things

[git at git.openembedded.org]

Module: openembedded-core.git
Branch: master-next
Commit: 2f09f425e6b7e942f711275943e71fe05c0a3e42
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=2f09f425e6b7e942f711275943e71fe05c0a3e42

Author: Richard Purdie <richard.purdie at linuxfoundation.org>
Date:   Thu Apr 19 21:52:10 2012 +0000

utils.bbclass: Testing via env in create_wrapper is a nice idea but breaks things

For example, pseudo-native wants to set LD_LIBRBARY_PATH but setting this
into the environment here causes the existing pseudo (running during do_install)
to poke into paths in /opt and this breaks builds.

The simplest fix is simply not to do this. Comments tweaks to match the code.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/utils.bbclass |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 3b59463..fde8f44 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -282,7 +282,6 @@ create_cmdline_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
    echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real
@@ -306,8 +305,7 @@ create_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
-   env $@ echo "Generating wrapper script for $cmd"
+   echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real
    cmdname=`basename $cmd`.real