[oe-commits] Javier Martinez Canillas : cronie: use variables instead of hardcoded paths

git at git.openembedded.org git at git.openembedded.org
Mon Aug 6 14:22:43 UTC 2012


Module: openembedded-core.git
Branch: master
Commit: 7b13be661c869eb4bf88d16a928a97edd5bc203b
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=7b13be661c869eb4bf88d16a928a97edd5bc203b

Author: Javier Martinez Canillas <javier at dowhile0.org>
Date:   Sun Aug  5 21:48:34 2012 +0200

cronie: use variables instead of hardcoded paths

It is considered good practice to use the build system provided
variables instead of directly specify hardcoded paths.

Signed-off-by: Javier Martinez Canillas <javier at dowhile0.org>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/recipes-extended/cronie/cronie_1.4.8.bb |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/meta/recipes-extended/cronie/cronie_1.4.8.bb b/meta/recipes-extended/cronie/cronie_1.4.8.bb
index 2d25627..ce59437 100644
--- a/meta/recipes-extended/cronie/cronie_1.4.8.bb
+++ b/meta/recipes-extended/cronie/cronie_1.4.8.bb
@@ -18,7 +18,7 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_DEPS}', '', d)}"
 PAM_DEPS = "libpam libpam-runtime pam-plugin-access pam-plugin-loginuid"
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
            file://crond.init \
@@ -61,14 +61,14 @@ do_install_append () {
 	# below setting is necessary to allow normal user using crontab
 
 	# setgid for crontab binary
-	chown root:crontab ${D}/usr/bin/crontab
-	chmod 2755 ${D}/usr/bin/crontab
+	chown root:crontab ${D}${bindir}/crontab
+	chmod 2755 ${D}${bindir}/crontab
 
 	# allow 'crontab' group write to /var/spool/cron
-	chown root:crontab ${D}/var/spool/cron
-	chmod 770 ${D}/var/spool/cron
+	chown root:crontab ${D}${localstatedir}/spool/cron
+	chmod 770 ${D}${localstatedir}/spool/cron
 
-	chmod 600 ${D}/etc/crontab
+	chmod 600 ${D}${sysconfdir}/crontab
 }
 
 FILES_${PN} += "${sysconfdir}/cron*"





More information about the Openembedded-commits mailing list