[oe-commits] Paul Eggleton : buildhistory_analysis: fix broken list length checks

git at git.openembedded.org git at git.openembedded.org
Thu Dec 6 13:54:05 UTC 2012


Module: openembedded-core.git
Branch: master
Commit: 63fd76190f503660119dcc8efdcfc6fbff406c26
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=63fd76190f503660119dcc8efdcfc6fbff406c26

Author: Paul Eggleton <paul.eggleton at linux.intel.com>
Date:   Thu Dec  6 11:11:51 2012 +0000

buildhistory_analysis: fix broken list length checks

Fix erroneous use of .count instead of len(), which unfortunately is not
reported by Python as an error in a numeric comparison.

Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/lib/oe/buildhistory_analysis.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oe/buildhistory_analysis.py b/meta/lib/oe/buildhistory_analysis.py
index ad57f00..7b5ee45 100644
--- a/meta/lib/oe/buildhistory_analysis.py
+++ b/meta/lib/oe/buildhistory_analysis.py
@@ -185,7 +185,7 @@ def blob_to_dict(blob):
     adict = {}
     for line in alines:
         splitv = [i.strip() for i in line.split('=',1)]
-        if splitv.count > 1:
+        if len(splitv) > 1:
             adict[splitv[0]] = splitv[1]
     return adict
 
@@ -231,7 +231,7 @@ def compare_file_lists(alines, blines):
                 filechanges.append(FileChange(path, FileChange.changetype_ownergroup, oldvalue, newvalue))
             # Check symlink target
             if newsplitv[0][0] == 'l':
-                if splitv.count > 3:
+                if len(splitv) > 3:
                     oldvalue = splitv[3]
                 else:
                     oldvalue = None





More information about the Openembedded-commits mailing list