[oe-commits] Enrico Scholz : package.bbclass: quote pathname given to objdump

git at git.openembedded.org git at git.openembedded.org
Tue Jan 17 15:19:31 UTC 2012


Module: openembedded-core.git
Branch: master
Commit: 7f7db286ca0b70bd5cce643c3b84f77ad45cc786
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=7f7db286ca0b70bd5cce643c3b84f77ad45cc786

Author: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>
Date:   Thu Jan 12 17:30:20 2012 +0100

package.bbclass: quote pathname given to objdump

Packaging will fail with executable files containing spaces in their
names. Patch quotes the parameter passed to 'objdump'.

Signed-off-by: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>

---

 meta/classes/package.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index f8f0a12..1088470 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1205,7 +1205,7 @@ SHLIBSDIR = "${STAGING_DIR_HOST}/shlibs"
 SHLIBSWORKDIR = "${WORKDIR}/shlibs"
 
 python package_do_shlibs() {
-	import re
+	import re, pipes
 
 	exclude_shlibs = d.getVar('EXCLUDE_FROM_SHLIBS', 0)
 	if exclude_shlibs:
@@ -1234,7 +1234,7 @@ python package_do_shlibs() {
 	lf = bb.utils.lockfile(bb.data.expand("${PACKAGELOCK}", d))
 
 	def linux_so(root, path, file):
-		cmd = d.getVar('OBJDUMP', True) + " -p " + os.path.join(root, file) + " 2>/dev/null"
+		cmd = d.getVar('OBJDUMP', True) + " -p " + pipes.quote(os.path.join(root, file)) + " 2>/dev/null"
 		cmd = "PATH=\"%s\" %s" % (d.getVar('PATH', True), cmd)
 		fd = os.popen(cmd)
 		lines = fd.readlines()





More information about the Openembedded-commits mailing list