[oe-commits] Kartik Mohta : gcc-common: Don't use "is" for comparing strings, use "=="
git at git.openembedded.org
git at git.openembedded.org
Mon Jul 9 16:00:38 UTC 2012
Module: openembedded-core.git
Branch: master
Commit: 7fd82cc90a48302ed42b6bfa962bb0de2c652b45
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=7fd82cc90a48302ed42b6bfa962bb0de2c652b45
Author: Kartik Mohta <kartikmohta at gmail.com>
Date: Tue Jul 3 23:21:07 2012 -0400
gcc-common: Don't use "is" for comparing strings, use "=="
Needed because the equality check was failing here even though upon
printing the LHS and RHS were the same.
As per http://stackoverflow.com/a/2987975/64537, using "is" compares the
memory addresses of the two objects which is not what we want here. We
just want to compare the values.
Signed-off-by: Kartik Mohta <kartikmohta at gmail.com>
---
meta/recipes-devtools/gcc/gcc-common.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index 45828bb..0a9324a 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -10,7 +10,7 @@ inherit autotools gettext
FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
def get_gcc_fpu_setting(bb, d):
- if d.getVar('ARMPKGSFX_EABI', True) is "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
+ if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm":
return "--with-float=hard"
if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
return "--with-float=soft"
More information about the Openembedded-commits
mailing list