[oe-commits] Robert P. J. Day : kernel-yocto.bbclass: Delete superfluous creation of ${S}/.git directory

git at git.openembedded.org git at git.openembedded.org
Fri Jul 20 16:25:17 UTC 2012


Module: openembedded-core.git
Branch: master-next
Commit: 46a66287177340b391642f8c5a99120c6b9abf25
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=46a66287177340b391642f8c5a99120c6b9abf25

Author: Robert P. J. Day <rpjday at crashcourse.ca>
Date:   Fri Jul 20 11:19:24 2012 -0400

kernel-yocto.bbclass: Delete superfluous creation of ${S}/.git directory

In do_kernel_checkout(), replace the creation of ${S}/.git with just
the creation of ${S} since the .git subdirectory is created only a few
lines later using a "mv".  Here's the original code:

  rm -rf ${S}
  mkdir -p ${S}/.git

  echo "WARNING. ${WORKDIR}/git is not a bare clone."
  echo "Ensure that the SRC_URI includes the 'bareclone=1' option."

  # we can fix up the kernel repository, but at the least the meta
  # branch must be present. The machine branch may be created later.
  mv ${WORKDIR}/git/.git ${S}    <-- See?  There it is.

There's no functional change here, it's just less confusing.

Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
Signed-off-by: Bruce Ashfield <bruce.ashfield at windriver.com>
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

---

 meta/classes/kernel-yocto.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 1e08faa..f09d503 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -106,7 +106,7 @@ do_kernel_checkout() {
 	if [ -d "${WORKDIR}/git/" ] && [ -d "${WORKDIR}/git/.git" ]; then
 		# we build out of {S}, so ensure that ${S} is clean and present
 		rm -rf ${S}
-		mkdir -p ${S}/.git
+		mkdir -p ${S}
 
 		echo "WARNING. ${WORKDIR}/git is not a bare clone."
 		echo "Ensure that the SRC_URI includes the 'bareclone=1' option."





More information about the Openembedded-commits mailing list