[oe-commits] Peter Seebach : sanity.bbclass: Detect empty $PATH components too

git at git.openembedded.org git at git.openembedded.org
Fri May 11 16:58:35 UTC 2012


Module: openembedded-core.git
Branch: master
Commit: ac4201b714c83c614113bfa735d0a2fc6f64db99
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=ac4201b714c83c614113bfa735d0a2fc6f64db99

Author: Peter Seebach <peter.seebach at windriver.com>
Date:   Wed May  9 15:14:41 2012 -0500

sanity.bbclass: Detect empty $PATH components too

Empty components in $PATH have the same effect as a . in $PATH,
and are a common side-effect of inserting a misspelled or unset
shell variable in $PATH.

Signed-off-by: Peter Seebach <peter.seebach at windriver.com>

---

 meta/classes/sanity.bbclass |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 635049e..05545f4 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -368,8 +368,9 @@ def check_sanity(e):
         if not check_app_exists("qemu-arm", e.data):
             messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
 
-    if "." in data.getVar('PATH', e.data, True).split(":"):
-        messages = messages + "PATH contains '.' which will break the build, please remove this"
+    paths = data.getVar('PATH', e.data, True).split(":")
+    if "." in paths or "" in paths:
+        messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
 
     if data.getVar('TARGET_ARCH', e.data, True) == "arm":
         # This path is no longer user-readable in modern (very recent) Linux





More information about the Openembedded-commits mailing list